Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

IraMladanovych02
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code meets the task requirements and constraints effectively. There are a couple of minor improvements you could consider: capitalizing 'Android studio' to 'Android Studio' for consistency, and adding an __init__ method in the FullStackDeveloper class to initialize its skills properly. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

return "Ads every three swipes"


class FullStackDeveloper(FrontendDeveloper, BackendDeveloper):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FullStackDeveloper class does not have an __init__ method to initialize its skills. Consider adding an __init__ method to initialize the skills by calling the __init__ methods of both FrontendDeveloper and BackendDeveloper.

class AndroidDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills.extend(["Java", "Android studio"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skill 'Android studio' should be capitalized as 'Android Studio' to maintain consistency with proper naming conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants