-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1259
base: master
Are you sure you want to change the base?
Solution #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code meets the task requirements and constraints effectively. There are a couple of minor improvements you could consider: capitalizing 'Android studio' to 'Android Studio' for consistency, and adding an __init__
method in the FullStackDeveloper
class to initialize its skills properly. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
return "Ads every three swipes" | ||
|
||
|
||
class FullStackDeveloper(FrontendDeveloper, BackendDeveloper): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FullStackDeveloper
class does not have an __init__
method to initialize its skills. Consider adding an __init__
method to initialize the skills by calling the __init__
methods of both FrontendDeveloper
and BackendDeveloper
.
class AndroidDeveloper(SoftwareEngineer): | ||
def __init__(self, name: str) -> None: | ||
super().__init__(name) | ||
self.skills.extend(["Java", "Android studio"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The skill 'Android studio' should be capitalized as 'Android Studio' to maintain consistency with proper naming conventions.
No description provided.