Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ takes a `skill` of string type and should add it to the `skills` list.
```python
engineer = SoftwareEngineer("Max")
# engineer.skills == []
engineer.learn_skill("Python")
learn_skill("Python")
# engineer.skills == ["Python"]
```

Expand Down
46 changes: 45 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,45 @@
# write your code here
class SoftwareEngineer:
def __init__(self, name: str) -> None:
self.name = name
self.skills = []

def learn_skill(self, skill: str) -> None:
self.skills.append(skill)


class FrontendDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills.extend(["JavaScript", "HTML", "CSS"])

def create_awesome_web_page(self) -> str:
print(f"{self.name} is creating a webpage...")
return "<h1>Hello world</h1>"


class BackendDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills += ["Python", "SQL", "Django"]

def create_powerful_api(self) -> str:
print(f"{self.name} is creating an API...")
return "http://127.0.0.1:8000"


class AndroidDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills.extend(["Java", "Android studio"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skill 'Android studio' should be capitalized as 'Android Studio' to maintain consistency with proper naming conventions.

def create_smooth_mobile_app(self) -> str:
print(f"{self.name} is creating a mobile app...")
return "Ads every three swipes"


class FullStackDeveloper(FrontendDeveloper, BackendDeveloper):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FullStackDeveloper class does not have an __init__ method to initialize its skills. Consider adding an __init__ method to initialize the skills by calling the __init__ methods of both FrontendDeveloper and BackendDeveloper.

def create_web_application(self) -> None:
print(f"{self.name} started creating a web application...")
self.create_powerful_api()
self.create_awesome_web_page()
Loading