Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #942

wants to merge 2 commits into from

Conversation

Valentyna08
Copy link

outofs
outofs approved these changes Jul 20, 2023
View reviewed changes
Copy link

@outofs outofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

And678
And678 suggested changes Jul 21, 2023
View reviewed changes
Copy link

@And678 And678 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are creating new arrow functions in componentDidMount and componentWillUnmount. Unmount will not work this way, you need to pass this.handleKeyUp directly to addEventListener and removeEventListener.

src/App.tsx Outdated
<p className="App__message">The last pressed key is [Enter]</p>
</div>
);
export class App extends React.PureComponent {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PureComponent is a class version of React.memo. No need for it here

Suggested change
export class App extends React.PureComponent {
export class App extends React.Component {

anstsot
anstsot approved these changes Jul 21, 2023
View reviewed changes
Copy link

@anstsot anstsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, approving:sparkles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@And678 And678 And678 requested changes

@anstsot anstsot anstsot approved these changes

@outofs outofs outofs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Valentyna08 @anstsot @And678 @outofs