Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ Make the `App` a class component with `pressedKey` in the `state`.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_keyboard/) and add it to the PR description.
- Replace `Valentyna08` with your Github username in the [DEMO LINK](https://Valentyna08.github.io/react_keyboard/) and add it to the PR description.
40 changes: 35 additions & 5 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,37 @@
import React from 'react';

export const App: React.FC = () => (
<div className="App">
<p className="App__message">The last pressed key is [Enter]</p>
</div>
);
export class App extends React.PureComponent {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PureComponent is a class version of React.memo. No need for it here

Suggested change
export class App extends React.PureComponent {
export class App extends React.Component {

state = {
pressedKey: '',
};

componentDidMount(): void {
document.addEventListener('keyup', (event: KeyboardEvent) => (
this.handleKeyUp(event)
));
}

componentWillUnmount(): void {
document.removeEventListener('keyup', (event: KeyboardEvent) => (
this.handleKeyUp(event)
));
}

handleKeyUp = (event: KeyboardEvent) => {
this.setState({ pressedKey: event.key });
};

render() {
const { pressedKey } = this.state;

return (
<div className="App">
<p className="App__message">
{ pressedKey
? `The last pressed key is [${pressedKey}]`
: 'Nothing was pressed yet'}
</p>
</div>
);
}
}
Loading