Ie 516 Update to be compatible with Ruby 3 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncperry
commented
Feb 1, 2024
•
ncperry
commented
- Added CI step
- Removed JSON as a gem. By using the system-level JSON module, instead of the JSON gem, we'll be guaranteed to have a version of the JSON library that is compatible with the ruby compiler.
- Updated tz-info gem as the older gem had a problem with ruby 3 style keyword arguments
- Updated rspec to be compatible with RubyMine
- Fixed a few tests that had been broken in previous PRs but that weren't caught
using the older gem implementation of json was introducing a arity error because of ruby 3 keywords
In #19 we changed the default version but we never updated the specs accordingly.
jarednielson
reviewed
Feb 1, 2024
jarednielson
reviewed
Feb 1, 2024
| @@ -56,7 +56,7 @@ | |||
|
|
|||
| context 'when the wsdl has not been set' do | |||
| it 'returns a path to the WSDL to use for the API' do | |||
| expect(config.wsdl).to eq("https://webservices.netsuite.com/wsdl/v2015_1_0/netsuite.wsdl") | |||
| expect(config.wsdl).to eq("https://webservices.netsuite.com/wsdl/v2023_1_0/netsuite.wsdl") | |||
There was a problem hiding this comment.
I am really curious why this was changed originally
jarednielson
approved these changes
Feb 1, 2024
jarednielson
reviewed
Feb 1, 2024
jarednielson
reviewed
Feb 1, 2024
wilkinsondesouza
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.