warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait --> src/api/handler.rs:223:35 | 223 | ... host: config.config.host.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.config.host` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/ui/src/plugin/channels/programmer.rs:276:26 | 276 | let programmer = Arc::new(programmer); | ^^^^^^^^^^^^^^^^^^^^ | = note: the trait `Send` is not implemented for `Programmer` = note: the trait `Sync` is not implemented for `Programmer` = note: required for `Arc<Programmer>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/ui/src/plugin/channels/nodes.rs:225:28 | 225 | let metadata_ref = Arc::new(NodesRef::new(metadata_ref)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: the trait `Send` is not implemented for `NodesRef` = note: the trait `Sync` is not implemented for `NodesRef` = note: required for `Arc<NodesRef>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/ui/src/plugin/channels/nodes.rs:193:27 | 193 | let preview = Arc::new(preview); | ^^^^^^^^^^^^^^^^^ | = note: the trait `Send` is not implemented for `NodeHistory` = note: the trait `Sync` is not implemented for `NodeHistory` = note: required for `Arc<NodeHistory>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

warning: useless conversion to the same type: `mizer_api::proto::surfaces::SurfaceTransform` --> crates/ui/src/plugin/channels/method/surfaces.rs:40:25 | 40 | req.transform.unwrap().into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `req.transform.unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: usage of an `Arc` that is not `Send` or `Sync` --> crates/ui/src/plugin/channels/layouts.rs:243:23 | 243 | let layouts = Arc::new(layouts); | ^^^^^^^^^^^^^^^^^ | = note: the trait `Send` is not implemented for `LayoutRef` = note: the trait `Sync` is not implemented for `LayoutRef` = note: required for `Arc<LayoutRef>` to implement `Send` and `Sync` = help: consider using an `Rc` instead or wrapping the inner type with a `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/transport.rs:22:15 | 22 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/transport.rs:10:15 | 10 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/timecode.rs:52:15 | 52 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/timecode.rs:42:15 | 42 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/timecode.rs:28:15 | 28 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/timecode.rs:13:15 | 13 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/settings.rs:55:15 | 55 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/settings.rs:38:15 | 38 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/settings.rs:22:15 | 22 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/settings.rs:13:15 | 13 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: useless conversion to the same type: `std::option::Option<proto::sequencer::CueTime>` --> crates/api/src/mappings/sequencer.rs:24:23 | 24 | time: cue.trigger_time.map(|time| time.into()).into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cue.trigger_time.map(|time| time.into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/sequencer.rs:25:19 | 25 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:300:15 | 300 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:291:23 | 291 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:275:23 | 275 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:227:15 | 227 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:216:19 | 216 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:195:15 | 195 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:174:15 | 174 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:163:15 | 163 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:142:15 | 142 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:109:19 | 109 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:104:19 | 104 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:99:19 | 99 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/programmer.rs:94:19 | 94 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/plans.rs:43:23 | 43 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/plans.rs:29:23 | 29 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/plans.rs:17:23 | 17 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/plans.rs:46:15 | 46 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:654:27 | 654 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:657:19 | 657 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:641:27 | 641 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:644:19 | 644 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:619:15 | 619 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:600:15 | 600 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: useless conversion to the same type: `std::iter::FilterMap<std::iter::Cloned<std::slice::Iter<'_, i32>>, fn(i32) -> std::option::Option<proto::media::MediaType>>` --> crates/api/src/mappings/nodes.rs:584:32 | 584 | content_types: value | ________________________________^ 585 | | .allowed_types() 586 | | .into_iter() | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 584 ~ content_types: value 585 + .allowed_types() |

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:520:19 | 520 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:508:19 | 508 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:503:19 | 503 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:495:19 | 495 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:487:19 | 487 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:479:19 | 479 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:475:19 | 475 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:461:19 | 461 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:447:19 | 447 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:433:19 | 433 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:408:15 | 408 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: useless conversion to the same type: `std::option::Option<proto::nodes::NodeConfig>` --> crates/api/src/mappings/nodes.rs:373:21 | 373 | config: descriptor.config.try_into().ok().into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `descriptor.config.try_into().ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:138:15 | 138 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:124:15 | 124 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/nodes.rs:36:15 | 36 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/media.rs:40:27 | 40 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: useless conversion to the same type: `std::option::Option<proto::media::media_metadata::Dimensions>` --> crates/api/src/mappings/media.rs:34:29 | 34 | dimensions: media | _____________________________^ 35 | | .metadata 36 | | .dimensions 37 | | .map(|(width, height)| media_metadata::Dimensions { ... | 41 | | }) 42 | | .into(), | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 34 ~ dimensions: media 35 + .metadata 36 + .dimensions 37 + .map(|(width, height)| media_metadata::Dimensions { 38 + width, 39 + height, 40 + ..Default::default() 41 ~ }), |

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/media.rs:47:19 | 47 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/media.rs:17:15 | 17 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: useless conversion to the same type: `std::option::Option<proto::layouts::Color>` --> crates/api/src/mappings/layouts.rs:92:20 | 92 | color: decorations.color.map(Color::from).into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `decorations.color.map(Color::from)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:303:23 | 303 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:305:19 | 305 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:297:19 | 297 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:287:15 | 287 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:251:15 | 251 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:240:15 | 240 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:223:27 | 223 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:226:19 | 226 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:208:23 | 208 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:210:19 | 210 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:195:23 | 195 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:197:19 | 197 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:178:23 | 178 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:180:19 | 180 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:156:19 | 156 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:146:19 | 146 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/fixtures.rs:22:15 | 22 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/effects.rs:69:19 | 69 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/effects.rs:61:23 | 61 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/effects.rs:48:15 | 48 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/effects.rs:25:15 | 25 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/effects.rs:15:15 | 15 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:276:23 | 276 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:267:19 | 267 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:261:19 | 261 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:255:19 | 255 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:242:15 | 242 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:235:19 | 235 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:200:15 | 200 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:190:15 | 190 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:178:15 | 178 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:164:15 | 164 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:145:15 | 145 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/mappings/connections.rs:8:15 | 8 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: this function has too many arguments (9/7) --> crates/api/src/handlers/mod.rs:66:5 | 66 | / pub fn new( 67 | | runtime: R, 68 | | fixture_manager: FixtureManager, 69 | | fixture_library: FixtureLibrary, ... | 75 | | surface_registry_api: SurfaceRegistryApi, 76 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/timecode.rs:37:15 | 37 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/session.rs:94:23 | 94 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/session.rs:87:27 | 87 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/sequencer.rs:26:15 | 26 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/programmer.rs:170:15 | 170 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/programmer.rs:140:15 | 140 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/plans.rs:32:15 | 32 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/nodes.rs:71:19 | 71 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/media.rs:33:15 | 33 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/layouts.rs:30:15 | 30 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/fixtures.rs:91:15 | 91 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/effects.rs:29:15 | 29 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/connections.rs:170:15 | 170 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

warning: struct update has no effect, all the fields in the struct have already been specified --> crates/api/src/handlers/connections.rs:34:15 | 34 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update = note: `#[warn(clippy::needless_update)]` on by default

warning: method `is_empty` is never used --> crates/runtime/commander/executor/src/history.rs:85:12 | 77 | impl<T> CommandCursor<T> { | ------------------------ method in this implementation ... 85 | pub fn is_empty(&self) -> bool { | ^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: you should consider adding a `Default` implementation for `CoordinatorRuntime<SystemClock>` --> crates/runtime/src/coordinator.rs:61:5 | 61 | / pub fn new() -> Self { 62 | | let clock = SystemClock::default(); 63 | | 64 | | Self::with_clock(clock) 65 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 60 + impl Default for CoordinatorRuntime<SystemClock> { 61 + fn default() -> Self { 62 + Self::new() 63 + } 64 + } |

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> crates/runtime/src/commands/update_node_setting.rs:63:26 | 63 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `#[warn(clippy::into_iter_on_ref)]` on by default

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:498:33 | 498 | nodes: &Vec<(&NodePath, &Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:448:37 | 448 | nodes: &mut Vec<(&NodePath, &Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:427:37 | 427 | nodes: &mut Vec<(&NodePath, &Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:406:37 | 406 | nodes: &mut Vec<(&NodePath, &Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> crates/runtime/pipeline/src/worker.rs:387:16 | 387 | nodes: &mut Vec<(&NodePath, &Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [(&NodePath, &Box<dyn ProcessingNodeExt>)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:387:37 | 387 | nodes: &mut Vec<(&NodePath, &Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:366:61 | 366 | fn check_node_receivers(&mut self, nodes: &[(&NodePath, &Box<dyn ProcessingNodeExt>)]) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:355:39 | 355 | mut nodes: Vec<(&'a NodePath, &'a Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:342:39 | 342 | mut nodes: Vec<(&'a NodePath, &'a Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T` --> crates/runtime/pipeline/src/worker.rs:329:39 | 329 | mut nodes: Vec<(&'a NodePath, &'a Box<dyn ProcessingNodeExt>)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn ProcessingNodeExt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box = note: `#[warn(clippy::borrowed_box)]` on by default

warning: use of `or_insert_with` to construct default value --> crates/runtime/pipeline/src/worker.rs:309:14 | 309 | .or_insert_with(NodeReceivers::default); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

warning: use of `or_insert_with` to construct default value --> crates/runtime/pipeline/src/worker.rs:292:14 | 292 | .or_insert_with(NodeSenders::default); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: large size difference between variants --> crates/runtime/pipeline/src/context.rs:51:1 | 51 | / pub enum NodePreviewState { 52 | |/ History( 53 | || ConstGenericRingBuffer<f64, HISTORY_PREVIEW_SIZE>, 54 | || Arc<NonEmptyPinboard<Vec<f64>>>, 55 | || ), | ||_____- the largest variant contains at least 1048 bytes 56 | | Data(Arc<NonEmptyPinboard<Option<StructuredData>>>), 57 | | Color(Arc<NonEmptyPinboard<Option<Color>>>), | | ------------------------------------------- the second-largest variant contains at least 8 bytes 58 | | None, 59 | | } | |__^ the entire enum is at least 0 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 53 | Box<ConstGenericRingBuffer<f64, HISTORY_PREVIEW_SIZE>>, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: field `reverse` is never read --> crates/runtime/pipeline/nodes/behaviors/oscillator/src/lib.rs:143:9 | 137 | struct OscillatorContext { | ----------------- field in this struct ... 143 | pub reverse: bool, | ^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> crates/runtime/pipeline/nodes/behaviors/color/src/constant.rs:199:1 | 199 | impl Into<u8> for ConstantColorNode { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<constant::ConstantColorNode>` | 199 ~ impl From<ConstantColorNode> for u8 { 200 ~ fn from(val: ConstantColorNode) -> Self { 201 ~ match val { 202 ~ ConstantColorNode::Rgb { .. } => 0, 203 ~ ConstantColorNode::Hsv { .. } => 1, |

warning: field `from` is never read --> crates/runtime/pipeline/nodes/behaviors/envelope/src/lib.rs:185:14 | 185 | Attack { from: f64, to: f64 }, | ------ ^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> crates/runtime/pipeline/nodes/connections/protocols/midi/src/output.rs:345:1 | 345 | impl Into<u8> for MidiOutputConfig { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<output::MidiOutputConfig>` | 345 ~ impl From<MidiOutputConfig> for u8 { 346 ~ fn from(val: MidiOutputConfig) -> Self { 347 ~ match val { 348 ~ MidiOutputConfig::Note { .. } => 0, 349 ~ MidiOutputConfig::Control { .. } => 1, |

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> crates/runtime/pipeline/nodes/connections/protocols/midi/src/input.rs:300:1 | 300 | impl Into<u8> for MidiInputConfig { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<input::MidiInputConfig>` | 300 ~ impl From<MidiInputConfig> for u8 { 301 ~ fn from(val: MidiInputConfig) -> Self { 302 ~ match val { 303 ~ MidiInputConfig::Note { .. } => 0, 304 ~ MidiInputConfig::Control { .. } => 1, |

warning: function `webcam_to_node_setting` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:136:4 | 136 | fn webcam_to_node_setting(value: WebcamSettingValue, setting: &'static str) -> NodeSetting { | ^^^^^^^^^^^^^^^^^^^^^^

warning: function `collect_webcam_settings` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:73:4 | 73 | fn collect_webcam_settings(webcam_ref: Option<&WebcamRef>) -> Vec<NodeSetting> { | ^^^^^^^^^^^^^^^^^^^^^^^

warning: constant `FOCUS_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:33:7 | 33 | const FOCUS_SETTING: &str = "Focus"; | ^^^^^^^^^^^^^

warning: constant `IRIS_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:32:7 | 32 | const IRIS_SETTING: &str = "Iris"; | ^^^^^^^^^^^^

warning: constant `EXPORURE_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:31:7 | 31 | const EXPORURE_SETTING: &str = "Exposure"; | ^^^^^^^^^^^^^^^^

warning: constant `ZOOM_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:30:7 | 30 | const ZOOM_SETTING: &str = "Zoom"; | ^^^^^^^^^^^^

warning: constant `TILT_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:29:7 | 29 | const TILT_SETTING: &str = "Tilt"; | ^^^^^^^^^^^^

warning: constant `PAN_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:28:7 | 28 | const PAN_SETTING: &str = "Pan"; | ^^^^^^^^^^^

warning: constant `GAIN_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:27:7 | 27 | const GAIN_SETTING: &str = "Gain"; | ^^^^^^^^^^^^

warning: constant `BACKLIGHT_COMPENSATION_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:26:7 | 26 | const BACKLIGHT_COMPENSATION_SETTING: &str = "Backlight Compensation"; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: constant `WHITE_BALANCE_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:25:7 | 25 | const WHITE_BALANCE_SETTING: &str = "White Balance"; | ^^^^^^^^^^^^^^^^^^^^^

warning: constant `GAMMA_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:24:7 | 24 | const GAMMA_SETTING: &str = "Gamma"; | ^^^^^^^^^^^^^

warning: constant `SHARPNESS_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:23:7 | 23 | const SHARPNESS_SETTING: &str = "Sharpness"; | ^^^^^^^^^^^^^^^^^

warning: constant `SATURATION_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:22:7 | 22 | const SATURATION_SETTING: &str = "Saturation"; | ^^^^^^^^^^^^^^^^^^

warning: constant `HUE_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:21:7 | 21 | const HUE_SETTING: &str = "Hue"; | ^^^^^^^^^^^

warning: constant `CONTRAST_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:20:7 | 20 | const CONTRAST_SETTING: &str = "Contrast"; | ^^^^^^^^^^^^^^^^

warning: constant `BRIGHTNESS_SETTING` is never used --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:19:7 | 19 | const BRIGHTNESS_SETTING: &str = "Brightness"; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `command` --> crates/runtime/pipeline/nodes/video/webcams/src/lib.rs:341:26 | 341 | fn handle(&mut self, command: Self::Commands) -> anyhow::Result<()> { | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command` | = note: `#[warn(unused_variables)]` on by default

warning: this `impl` can be derived --> crates/runtime/pipeline/nodes/audio/src/file.rs:230:1 | 230 | / impl Default for AudioFileNodeState { 231 | | fn default() -> Self { 232 | | Self { 233 | | paused: false, ... | 237 | | } 238 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 224 + #[derive(Default)] 225 | pub struct AudioFileNodeState { |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> crates/runtime/pipeline/nodes/audio/src/file.rs:176:13 | 176 | / match state.recv.try_recv() { 177 | | Ok(mut player) => { 178 | | tracing::debug!("Received decoded file {path:?} from decoding thread"); 179 | | if node_state.playing { ... | 184 | | Err(_) => {} 185 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 176 ~ if let Ok(mut player) = state.recv.try_recv() { 177 + tracing::debug!("Received decoded file {path:?} from decoding thread"); 178 + if node_state.playing { 179 + player.play(); 180 + } 181 + state.player = Some(player) 182 + } |

warning: fields `device` and `stream` are never read --> crates/runtime/pipeline/nodes/audio/src/output.rs:58:5 | 56 | pub struct AudioOutputNodeState { | -------------------- fields in this struct 57 | buffer: SpscRb<f32>, 58 | device: Device, | ^^^^^^ 59 | stream: Stream, | ^^^^^^

warning: fields `device` and `stream` are never read --> crates/runtime/pipeline/nodes/audio/src/input.rs:58:5 | 56 | pub struct AudioInputNodeState { | ------------------- fields in this struct 57 | buffer: SpscRb<f32>, 58 | device: Device, | ^^^^^^ 59 | stream: Stream, | ^^^^^^

warning: field `thread_handle` is never read --> crates/runtime/pipeline/nodes/audio/src/file.rs:244:5 | 240 | pub struct AudioFileDecodeState { | -------------------- field in this struct ... 244 | thread_handle: JoinHandle<anyhow::Result<()>>, | ^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: you should consider adding a `Default` implementation for `ImageId` --> crates/components/plan/src/lib.rs:110:5 | 110 | / pub fn new() -> Self { 111 | | Self(Uuid::new_v4()) 112 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 109 + impl Default for ImageId { 110 + fn default() -> Self { 111 + Self::new() 112 + } 113 + } |

warning: field `start_time` is never read --> crates/components/sequencer/src/state.rs:147:9 | 146 | pub(crate) struct CueChannel { | ---------- field in this struct 147 | pub start_time: SequenceTimestamp, | ^^^^^^^^^^ | = note: `CueChannel` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

warning: method `has_passed` is never used --> crates/components/sequencer/src/state.rs:118:19 | 117 | impl SequenceTimestamp { | ---------------------- method in this implementation 118 | pub(crate) fn has_passed( | ^^^^^^^^^^

warning: associated function `new` is never used --> crates/components/sequencer/src/cue.rs:293:19 | 292 | impl CueControl { | --------------- associated function in this implementation 293 | pub(crate) fn new( | ^^^

warning: associated function `new` is never used --> crates/components/sequencer/src/cue.rs:46:19 | 45 | impl Cue { | -------- associated function in this implementation 46 | pub(crate) fn new(id: u32, name: impl Into<String>, controls: Vec<CueControl>) -> Self { | ^^^ | = note: `#[warn(dead_code)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/runtime/pipeline/nodes/video/src/mixer/wgpu_pipeline.rs:233:13 | 233 | &self.shaders.get_shader(mode), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.shaders.get_shader(mode)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: casting integer literal to `u32` is unnecessary --> crates/runtime/pipeline/nodes/video/src/mixer/wgpu_pipeline.rs:166:32 | 166 | contents: &(1 as u32).to_ne_bytes(), | ^^^^^^^^^^ help: try: `1_u32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: associated items `new` and `iter` are never used --> crates/runtime/pipeline/nodes/pixels/src/pattern/mod.rs:179:12 | 178 | impl<'a> PixelGrid<'a> { | ---------------------- associated items in this implementation 179 | pub fn new(pixels: &'a mut [(f64, f64, f64)], (width, height): (usize, usize)) -> Self { | ^^^ ... 203 | pub fn iter(&self) -> impl Iterator<Item = &(f64, f64, f64)> { | ^^^^ | = note: `#[warn(dead_code)]` on by default

warning: the borrowed expression implements the required traits --> crates/components/media/src/media_handlers/video_handler.rs:165:20 | 165 | image.save(&target)?; | ^^^^^^^ help: change this to: `target` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: you should consider adding a `Default` implementation for `MediaId` --> crates/components/media/src/documents/mod.rs:21:5 | 21 | / pub fn new() -> Self { 22 | | MediaId(uuid::Uuid::new_v4()) 23 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 20 + impl Default for MediaId { 21 + fn default() -> Self { 22 + Self::new() 23 + } 24 + } |

warning: associated function `transcode_command` is never used --> crates/components/media/src/media_handlers/video_handler.rs:44:8 | 14 | impl VideoHandler { | ----------------- associated function in this implementation ... 44 | fn transcode_command<I: AsRef<OsStr>, O: AsRef<OsStr>>( | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: this function has too many arguments (9/7) --> crates/components/fixtures/src/manager.rs:46:5 | 46 | / pub fn add_fixture( 47 | | &self, 48 | | fixture_id: u32, 49 | | name: String, ... | 55 | | configuration: FixtureConfiguration, 56 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> crates/components/fixtures/src/fixture.rs:51:5 | 51 | / pub fn new( 52 | | fixture_id: u32, 53 | | name: String, 54 | | definition: FixtureDefinition, ... | 59 | | configuration: FixtureConfiguration, 60 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: unused variable: `amber` --> crates/components/fixtures/src/color_mixer.rs:134:13 | 134 | amber, | ^^^^^ help: try ignoring the field: `amber: _` | = note: `#[warn(unused_variables)]` on by default

warning: you should consider adding a `Default` implementation for `WebcamDiscovery` --> crates/components/connections/devices/webcams/src/discovery.rs:41:5 | 41 | / pub fn new() -> Self { 42 | | let (sender, receiver) = unbounded(); 43 | | 44 | | if !nokhwa_check() { ... | 54 | | Self { cameras: receiver } 55 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 40 + impl Default for WebcamDiscovery { 41 + fn default() -> Self { 42 + Self::new() 43 + } 44 + } |

warning: this `if let` can be collapsed into the outer `if let` --> crates/components/connections/protocols/pro-dj-link/src/discovery.rs:85:29 | 85 | / ... if let ProDJLinkDevice::CDJ(cdj) = device { 86 | | ... cdj.speed = packet.speed; 87 | | ... cdj.beat = packet.beat; 88 | | ... if let Err(err) = sender.send(ProDJLinkDevice::CDJ(cdj.clone())) { 89 | | ... log::error!("Failed to send CDJ device: {err:?}"); 90 | | ... } 91 | | ... } | |_______________________^ | help: the outer pattern can be modified to include the inner pattern --> crates/components/connections/protocols/pro-dj-link/src/discovery.rs:84:37 | 84 | if let Some(device) = devices.get_mut(&packet.device_id) { | ^^^^^^ replace this binding 85 | if let ProDJLinkDevice::CDJ(cdj) = device { | ^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match = note: `#[warn(clippy::collapsible_match)]` on by default

warning: useless conversion to the same type: `std::string::String` --> crates/runtime/pipeline/node/src/settings.rs:283:20 | 283 | value: value.into(), | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: unused variable: `state` --> crates/runtime/pipeline/node/src/lib.rs:103:9 | 103 | state: &mut Self::State, | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

warning: unused variable: `context` --> crates/runtime/pipeline/node/src/lib.rs:102:9 | 102 | context: &impl NodeContext, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context`

warning: unused variable: `state` --> crates/runtime/pipeline/node/src/lib.rs:93:9 | 93 | state: &mut Self::State, | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`

warning: unused variable: `context` --> crates/runtime/pipeline/node/src/lib.rs:92:9 | 92 | context: &impl NodeContext, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` | = note: `#[warn(unused_variables)]` on by default

warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait --> crates/components/connections/protocols/dmx/src/commands/add_artnet_input.rs:29:38 | 29 | let input = ArtnetInput::new(self.host.clone(), self.port, self.name.clone())?; | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.host` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: field `thread` is never read --> crates/components/connections/protocols/dmx/src/inputs/artnet.rs:80:5 | 79 | struct ThreadHandle { | ------------ field in this struct 80 | thread: JoinHandle<()>, | ^^^^^^ | = note: `ThreadHandle` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: irrefutable `if let` pattern --> crates/components/connections/protocols/dmx/src/commands/configure_artnet_input.rs:54:12 | 54 | if let DmxInputConnection::Artnet(input) = input { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this pattern will always match, so the `if let` is useless = help: consider replacing the `if let` with a `let`

warning: irrefutable `if let` pattern --> crates/components/connections/protocols/dmx/src/commands/configure_artnet_input.rs:33:12 | 33 | if let DmxInputConnection::Artnet(input) = input { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this pattern will always match, so the `if let` is useless = help: consider replacing the `if let` with a `let` = note: `#[warn(irrefutable_let_patterns)]` on by default

warning: you should consider adding a `Default` implementation for `EventLoopHandle` --> crates/runtime/wgpu/src/window/event_loop.rs:24:5 | 24 | / pub fn new() -> Self { 25 | | let mut builder = EventLoopBuilder::new(); 26 | | #[cfg(target_os = "linux")] 27 | | builder.with_any_thread(true); ... | 33 | | } 34 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 23 + impl Default for EventLoopHandle { 24 + fn default() -> Self { 25 + Self::new() 26 + } 27 + } |

warning: very complex type used. Consider factoring parts into `type` definitions --> crates/runtime/commander/src/extractors/sub_command.rs:11:39 | 11 | pub fn apply(self, command: T) -> anyhow::Result<(T::Result, (T, T::State))> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: returning the result of a `let` binding from a block --> crates/runtime/wgpu/src/context.rs:70:9 | 59 | / let texture = self.device.create_texture(&wgpu::TextureDescriptor { 60 | | label, 61 | | size, 62 | | mip_level_count: 1, ... | 67 | | view_formats: &[format], 68 | | }); | |___________- unnecessary `let` binding 69 | 70 | texture | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 59 ~ 60 | 61 ~ self.device.create_texture(&wgpu::TextureDescriptor { 62 + label, 63 + size, 64 + mip_level_count: 1, 65 + sample_count: 1, 66 + dimension: wgpu::TextureDimension::D2, 67 + format, 68 + usage, 69 + view_formats: &[format], 70 + }) |

warning: unneeded unit expression --> crates/runtime/debug-ui/src/noop.rs:34:9 | 34 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit