feat(video/surfaces): add surface mapping node (#358) [WIP] #144
clippy
185 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 185 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 223 in src/api/handler.rs
github-actions / clippy
using `clone` on type `Ipv4Addr` which implements the `Copy` trait
warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait
--> src/api/handler.rs:223:35
|
223 | ... host: config.config.host.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.config.host`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
Check warning on line 276 in crates/ui/src/plugin/channels/programmer.rs
github-actions / clippy
usage of an `Arc` that is not `Send` or `Sync`
warning: usage of an `Arc` that is not `Send` or `Sync`
--> crates/ui/src/plugin/channels/programmer.rs:276:26
|
276 | let programmer = Arc::new(programmer);
| ^^^^^^^^^^^^^^^^^^^^
|
= note: the trait `Send` is not implemented for `Programmer`
= note: the trait `Sync` is not implemented for `Programmer`
= note: required for `Arc<Programmer>` to implement `Send` and `Sync`
= help: consider using an `Rc` instead or wrapping the inner type with a `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
Check warning on line 225 in crates/ui/src/plugin/channels/nodes.rs
github-actions / clippy
usage of an `Arc` that is not `Send` or `Sync`
warning: usage of an `Arc` that is not `Send` or `Sync`
--> crates/ui/src/plugin/channels/nodes.rs:225:28
|
225 | let metadata_ref = Arc::new(NodesRef::new(metadata_ref));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: the trait `Send` is not implemented for `NodesRef`
= note: the trait `Sync` is not implemented for `NodesRef`
= note: required for `Arc<NodesRef>` to implement `Send` and `Sync`
= help: consider using an `Rc` instead or wrapping the inner type with a `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
Check warning on line 193 in crates/ui/src/plugin/channels/nodes.rs
github-actions / clippy
usage of an `Arc` that is not `Send` or `Sync`
warning: usage of an `Arc` that is not `Send` or `Sync`
--> crates/ui/src/plugin/channels/nodes.rs:193:27
|
193 | let preview = Arc::new(preview);
| ^^^^^^^^^^^^^^^^^
|
= note: the trait `Send` is not implemented for `NodeHistory`
= note: the trait `Sync` is not implemented for `NodeHistory`
= note: required for `Arc<NodeHistory>` to implement `Send` and `Sync`
= help: consider using an `Rc` instead or wrapping the inner type with a `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
Check warning on line 40 in crates/ui/src/plugin/channels/method/surfaces.rs
github-actions / clippy
useless conversion to the same type: `mizer_api::proto::surfaces::SurfaceTransform`
warning: useless conversion to the same type: `mizer_api::proto::surfaces::SurfaceTransform`
--> crates/ui/src/plugin/channels/method/surfaces.rs:40:25
|
40 | req.transform.unwrap().into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `req.transform.unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
Check warning on line 243 in crates/ui/src/plugin/channels/layouts.rs
github-actions / clippy
usage of an `Arc` that is not `Send` or `Sync`
warning: usage of an `Arc` that is not `Send` or `Sync`
--> crates/ui/src/plugin/channels/layouts.rs:243:23
|
243 | let layouts = Arc::new(layouts);
| ^^^^^^^^^^^^^^^^^
|
= note: the trait `Send` is not implemented for `LayoutRef`
= note: the trait `Sync` is not implemented for `LayoutRef`
= note: required for `Arc<LayoutRef>` to implement `Send` and `Sync`
= help: consider using an `Rc` instead or wrapping the inner type with a `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
= note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
Check warning on line 22 in crates/api/src/mappings/transport.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/transport.rs:22:15
|
22 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 10 in crates/api/src/mappings/transport.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/transport.rs:10:15
|
10 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 52 in crates/api/src/mappings/timecode.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/timecode.rs:52:15
|
52 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 42 in crates/api/src/mappings/timecode.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/timecode.rs:42:15
|
42 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 28 in crates/api/src/mappings/timecode.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/timecode.rs:28:15
|
28 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 13 in crates/api/src/mappings/timecode.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/timecode.rs:13:15
|
13 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 55 in crates/api/src/mappings/settings.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/settings.rs:55:15
|
55 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 38 in crates/api/src/mappings/settings.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/settings.rs:38:15
|
38 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 22 in crates/api/src/mappings/settings.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/settings.rs:22:15
|
22 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 13 in crates/api/src/mappings/settings.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/settings.rs:13:15
|
13 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 24 in crates/api/src/mappings/sequencer.rs
github-actions / clippy
useless conversion to the same type: `std::option::Option<proto::sequencer::CueTime>`
warning: useless conversion to the same type: `std::option::Option<proto::sequencer::CueTime>`
--> crates/api/src/mappings/sequencer.rs:24:23
|
24 | time: cue.trigger_time.map(|time| time.into()).into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cue.trigger_time.map(|time| time.into())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check warning on line 25 in crates/api/src/mappings/sequencer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/sequencer.rs:25:19
|
25 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 300 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:300:15
|
300 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 291 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:291:23
|
291 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 275 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:275:23
|
275 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 227 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:227:15
|
227 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 216 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:216:19
|
216 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 195 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:195:15
|
195 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
Check warning on line 174 in crates/api/src/mappings/programmer.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> crates/api/src/mappings/programmer.rs:174:15
|
174 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update