Skip to content

✨ [#550] Add cache to retrieve versions of objecttypes#571

Merged
danielmursa-dev merged 5 commits intomasterfrom
feature/550-implement-cache-for-objecttypes
May 1, 2025
Merged

✨ [#550] Add cache to retrieve versions of objecttypes#571
danielmursa-dev merged 5 commits intomasterfrom
feature/550-implement-cache-for-objecttypes

Conversation

@danielmursa-dev
Copy link
Contributor

Fixes #550

  • Implemented cache for objects
  • Added env var for timeout

@danielmursa-dev danielmursa-dev force-pushed the feature/550-implement-cache-for-objecttypes branch 4 times, most recently from fb9fef4 to 35ecc51 Compare April 22, 2025 10:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 91.89189% with 18 lines in your changes missing coverage. Please review.

Project coverage is 94.65%. Comparing base (9944d6a) to head (0a9967f).

Files with missing lines Patch % Lines
src/objects/core/models.py 20.00% 8 Missing ⚠️
src/objects/utils/client.py 84.78% 7 Missing ⚠️
src/objects/api/validators.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   94.57%   94.65%   +0.07%     
==========================================
  Files         144      147       +3     
  Lines        4941     5103     +162     
==========================================
+ Hits         4673     4830     +157     
- Misses        268      273       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

@danielmursa-dev danielmursa-dev force-pushed the feature/550-implement-cache-for-objecttypes branch 3 times, most recently from 744e73e to 3814da7 Compare April 29, 2025 14:02
@danielmursa-dev danielmursa-dev force-pushed the feature/550-implement-cache-for-objecttypes branch from cce9949 to d53c0b4 Compare April 29, 2025 14:18
@danielmursa-dev danielmursa-dev force-pushed the feature/550-implement-cache-for-objecttypes branch 2 times, most recently from 0c0b1ab to 2e0de31 Compare May 1, 2025 10:26
@danielmursa-dev danielmursa-dev requested a review from stevenbal May 1, 2025 10:32
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor test stuff, looks good otherwise

@danielmursa-dev danielmursa-dev force-pushed the feature/550-implement-cache-for-objecttypes branch from 2e0de31 to 0a9967f Compare May 1, 2025 11:44
@danielmursa-dev danielmursa-dev merged commit a76ead3 into master May 1, 2025
21 checks passed
@danielmursa-dev danielmursa-dev deleted the feature/550-implement-cache-for-objecttypes branch May 1, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid repeatedly retrieving the same objecttype when creating many new objects

3 participants