Skip to content

♻️ [maykinmedia/open-api-framework#175] Improve handled_exception#682

Merged
stevenbal merged 1 commit intomasterfrom
feature/improve-exception-handler-with-structlog
Oct 6, 2025
Merged

♻️ [maykinmedia/open-api-framework#175] Improve handled_exception#682
stevenbal merged 1 commit intomasterfrom
feature/improve-exception-handler-with-structlog

Conversation

@danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Oct 2, 2025

Fixes maykinmedia/open-api-framework#175

  • Added structlog event for API HTTP_400_BAD_REQUEST exceptions
  • Fixed error for generic error / exceptions message instead 500 page error

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.33%. Comparing base (7a50add) to head (1747ec6).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/objects/utils/views.py 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   82.37%   82.33%   -0.04%     
==========================================
  Files         130      130              
  Lines        2451     2463      +12     
  Branches      198      200       +2     
==========================================
+ Hits         2019     2028       +9     
- Misses        391      392       +1     
- Partials       41       43       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch 5 times, most recently from da91692 to 6edaf28 Compare October 2, 2025 13:17
danielmursa-dev added a commit to maykinmedia/objecttypes-api that referenced this pull request Oct 2, 2025
@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from 6edaf28 to a85abff Compare October 2, 2025 13:41
danielmursa-dev added a commit to maykinmedia/objecttypes-api that referenced this pull request Oct 2, 2025
@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch 2 times, most recently from 2f70981 to d04ee25 Compare October 2, 2025 13:43
danielmursa-dev added a commit to maykinmedia/objecttypes-api that referenced this pull request Oct 2, 2025
@stevenbal stevenbal mentioned this pull request Oct 3, 2025
14 tasks
@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from d04ee25 to 7f7a9ed Compare October 3, 2025 14:19
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing remaining, other than that good to merge

@stevenbal stevenbal force-pushed the feature/improve-exception-handler-with-structlog branch from 7f7a9ed to 1747ec6 Compare October 6, 2025 07:22
danielmursa-dev added a commit to maykinmedia/objecttypes-api that referenced this pull request Oct 6, 2025
@stevenbal stevenbal merged commit 33e8582 into master Oct 6, 2025
27 checks passed
@stevenbal stevenbal deleted the feature/improve-exception-handler-with-structlog branch October 6, 2025 07:29
danielmursa-dev added a commit to maykinmedia/objecttypes-api that referenced this pull request Oct 6, 2025
danielmursa-dev added a commit to maykinmedia/objecttypes-api that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logs for error responses should include the error code/detail

3 participants