Merged
Conversation
SonnyBA
commented
Jan 10, 2025
joeribekker
approved these changes
Jan 10, 2025
stevenbal
requested changes
Jan 10, 2025
Seems related to a update of drf-nested-routers>=0.93.4
stevenbal
approved these changes
Jan 16, 2025
stevenbal
reviewed
Jan 16, 2025
README.NL.rst
Outdated
| latest n/a `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/master/src/objecttypes/api/v2/openapi.yaml>`_, | ||
| `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/master/src/objecttypes/api/v2/openapi.yaml>`_, | ||
| (`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/2.2.2..master#diff-b9c28fec6c3f3fa5cff870d24601d6ab7027520f3b084cc767aefd258cb8c40a>`_) | ||
| (`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/3.0.0..master>`_) |
Collaborator
There was a problem hiding this comment.
Actually upon looking at this again, I'm not sure if this file was correct to begin with. It mentions version 3.0.0 and 2.3.0 and so on, but I think these correspond with the version of the application rather than the version of the API spec, because in this release branch the version of the API is 2.2.2.
It might be good to check with Joeri if this is right
Contributor
Author
There was a problem hiding this comment.
This is more of a problem in the Objects-API RTD documentation, see discussion. In this project I updated the README columns to include the application version instead of just version (which might confuse people, e.g is it the application version or the specification version?).
stevenbal
reviewed
Jan 16, 2025
stevenbal
reviewed
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes maykinmedia/objects-api#513
Changes
Adds changes required for releasing 3.0.0. This is the major release part.