Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to include environment variables #90

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

jtquach1
Copy link
Contributor

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

This pull request lists environment variables and GitHub Secrets used in these related repositories at the following commits:

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-410

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

EnvironmentVariables.md Show resolved Hide resolved
EnvironmentVariables.md Show resolved Hide resolved
@jtquach1 jtquach1 force-pushed the rems-410-update-documentation branch from dee99a2 to ce59995 Compare June 19, 2023 18:19
@jtquach1 jtquach1 force-pushed the rems-410-update-documentation branch from 1fb406c to e0a7303 Compare June 27, 2023 21:51
@jtquach1 jtquach1 marked this pull request as ready for review June 27, 2023 21:54
@jtquach1
Copy link
Contributor Author

Just rebased off origin/dev at 00879b0, but I haven't included any environment variables that could've been potentially added from then.

Copy link
Contributor

@zacharyrobin zacharyrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zacharyrobin zacharyrobin merged commit 863b273 into dev Jul 5, 2023
9 checks passed
@zacharyrobin zacharyrobin deleted the rems-410-update-documentation branch July 5, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants