Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RawDataRecord with unit tests #297

Merged
merged 10 commits into from
Nov 28, 2024
Merged

RawDataRecord with unit tests #297

merged 10 commits into from
Nov 28, 2024

Conversation

n135c10r
Copy link
Collaborator

Description

Draft of Implementation for RawDataRecord with unit tests.
Refactoring the Data Records directory structure.

How Has This Been Tested?

Executing unit tests.

Process

I know the process and did my best to follow it

@n135c10r n135c10r added this to the 6) Database introduction milestone Nov 10, 2024
@n135c10r n135c10r added the implementation Changes to code label Nov 10, 2024
@n135c10r n135c10r changed the title RawDataRecord with unit tests [Draft] RawDataRecord with unit tests Nov 10, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Nov 11, 2024 that may be closed by this pull request
Introduce Raw Data Record (signal for message database) #2
Closed
mdabrowski1990
mdabrowski1990 requested changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you separated data_record module.
I have left plenty of comments, but I think this is a really good start.

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c65988b) to head (91aa3d1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #297   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        48    +2     
  Lines         2818      2859   +41     
  Branches       345       351    +6     
=========================================
+ Hits          2818      2859   +41
Flag Coverage Δ
integration-tests 80.79% <53.06%> (-0.54%) ⬇️
integration-tests-branch 75.83% <53.06%> (-0.47%) ⬇️
unit-tests 100.00% <100.00%> (ø)
unit-tests-branch 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
uds/database/__init__.py 100.00% <100.00%> (ø)
uds/database/data_record/__init__.py 100.00% <100.00%> (ø)
uds/database/data_record/abstract_data_record.py 100.00% <100.00%> (ø)
uds/database/data_record/raw_data_record.py 100.00% <100.00%> (ø)
uds/database/services/abstract_service.py 100.00% <100.00%> (ø)

@n135c10r n135c10r changed the title [Draft] RawDataRecord with unit tests RawDataRecord with unit tests Nov 12, 2024
@n135c10r n135c10r marked this pull request as ready for review November 12, 2024 21:06
@mdabrowski1990 mdabrowski1990 mentioned this pull request Nov 20, 2024
Merged
mdabrowski1990
mdabrowski1990 reviewed Nov 26, 2024
View reviewed changes
Copy link
Owner

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost ready to be merged
please check why codecov reports missing coverage (there is something wrong with TypeError tests, probably it would be solved after my comments are applied)

@n135c10r n135c10r merged commit 8a6b3f8 into mdabrowski1990:main Nov 28, 2024
34 checks passed
@n135c10r n135c10r deleted the raw-data-record branch November 28, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdabrowski1990 mdabrowski1990 mdabrowski1990 approved these changes

Assignees

@n135c10r n135c10r

Labels
implementation Changes to code
Projects
None yet
Milestone
6) Database introduction
Development

Successfully merging this pull request may close these issues.

Introduce Raw Data Record (signal for message database)
2 participants
@n135c10r @mdabrowski1990