Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relnote(116): support dirname on textarea and input elements #28032

Merged
merged 5 commits into from
Jul 19, 2023
Merged

relnote(116): support dirname on textarea and input elements #28032

merged 5 commits into from
Jul 19, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 18, 2023 •
edited
Loading

Adding a release note for dirname on <textarea> and <input> elements:

<form action="page.html" method="post">
  <label
    >Fruit:
    <input type="text" name="fruit" dirname="fruit.dir" value="cherry" />
  </label>
  <input type="submit" />
</form>
<!-- page.html?fruit=cherry&fruit.dir=ltr -->
<textarea cols="90" name="info" dirname="info.dir"></textarea>

Related issues and pull requests:

Bugzilla:

@bsmth bsmth requested review from a team as code owners July 18, 2023 14:24
@bsmth bsmth requested review from dipikabh and removed request for a team July 18, 2023 14:24
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:Firefox Content in the Mozilla/Firefox subtree labels Jul 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/116
Title: Firefox 116 for developers

(comment last updated: 2023-07-19 08:36:02)

@bsmth bsmth mentioned this pull request Jul 18, 2023
Closed
12 tasks
@estelle estelle self-assigned this Jul 19, 2023
dipikabh
dipikabh requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bsmth! I've marked a few suggestions and questions.

files/en-us/mozilla/firefox/releases/116/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/textarea/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/textarea/index.md Outdated Show resolved Hide resolved
bsmth and others added 3 commits July 19, 2023 10:25
@bsmth @dipikabh
Update files/en-us/mozilla/firefox/releases/116/index.md
4dfd827 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@bsmth @dipikabh
Update files/en-us/web/html/element/textarea/index.md
e50bb18 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@bsmth
relnote(116): Remove example in description list
ec543ff
dipikabh
dipikabh approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bsmth. The updates look good to me 👍

@estelle estelle merged commit 2e181c6 into mdn:main Jul 19, 2023
6 checks passed
@bsmth bsmth deleted the 27760-dirname branch July 27, 2023 12:32
@bsmth bsmth mentioned this pull request Jul 31, 2023
Merged
2 tasks
@bsmth bsmth mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@dipikabh dipikabh dipikabh approved these changes

Assignees

@estelle estelle

Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:HTML Hypertext Markup Language docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsmth @estelle @dipikabh