-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dirname apply to hidden/tel/url/email inputs. #28146
Conversation
Preview URLs (comment last updated: 2023-08-10 10:02:41) |
Thanks a lot for the suggestions @vinhill - Is it correct that we're still waiting for implementations? We need at least one browser to support this before we merge. I've added the appropriate label for now. |
@bsmth you're right. The spec just merged and I can add a note here once the change landed in Firefox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinhill looks good, thanks! I've made a nitpicky suggestion on the attribute description, first to add a serial comma as per MDN style, and second to make some small changes to make the last sentence just a little bit easier to parse.
I've approved this, and we can get it merged when the change actually drops in Firefox.
The change landed, see mozilla/gecko-dev@6bb941a. @chrisdavidmills |
Sorry, I thought it was already in Nightly, but that is not the case yet. |
By now the change is applied to Nightly. |
Shall we also update https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes#attribute_list with a description and a link to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/dirname? |
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding my +1 here.
See also:
See whatwg/html#9490
Dirname should soon apply to input elements of type hidden/tel/url/email in addition to text and search.