Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): Add dirname attribute page #28296

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 31, 2023

@bsmth bsmth requested a review from a team as a code owner July 31, 2023 10:04
@bsmth bsmth requested review from chrisdavidmills and removed request for a team July 31, 2023 10:04
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Preview URLs

(comment last updated: 2023-07-31 12:57:15)

@Rumyra Rumyra requested review from Rumyra and removed request for chrisdavidmills July 31, 2023 10:13
files/en-us/web/html/attributes/dirname/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/attributes/dirname/index.md Outdated Show resolved Hide resolved
@Rumyra Rumyra self-requested a review July 31, 2023 12:51
bsmth and others added 2 commits July 31, 2023 14:53
Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
@Rumyra
Copy link
Collaborator

Rumyra commented Jul 31, 2023

Looks great @bsmth 👍

@Rumyra Rumyra merged commit 62b2885 into mdn:main Jul 31, 2023
7 checks passed
@bsmth bsmth deleted the dirname-attr-page branch July 31, 2023 14:44
@bsmth
Copy link
Member Author

bsmth commented Jul 31, 2023

Thank you 👍🏻

@bsmth
Copy link
Member Author

bsmth commented Jul 31, 2023

@vinhill FYI there's a dedicated page for this attr now. We should focus docs improvements & specifics about the behavior there.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants