Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32341 text wrap #32728

Merged
merged 14 commits into from
Mar 19, 2024
Merged

32341 text wrap #32728

merged 14 commits into from
Mar 19, 2024

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Mar 18, 2024 •
edited
Loading

Description

  • made text-wrap a shorthand property
  • added page for text-wrap-mode
  • added page for text-wrap-style
  • added link on shorthand properties to text-wrap

Motivation

Working on the Convert text-wrap CSS property to a shorthand Issue

Related issues and pull requests

@dletorey dletorey requested a review from a team as a code owner March 18, 2024 16:04
@dletorey dletorey requested review from bsmth and removed request for a team March 18, 2024 16:04
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 18, 2024
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Mar 18, 2024
This was referenced Mar 18, 2024
Merged
Merged
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-03-19 11:28:12)

This was referenced Mar 18, 2024
Merged
Closed
pepelsbey
pepelsbey reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d suggest an improvement to the demo and a small fix. Otherwise, looks good to me :) Thanks!

files/en-us/web/css/text-wrap-mode/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/text-wrap-mode/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/text-wrap-style/index.md Outdated Show resolved Hide resolved
@pepelsbey pepelsbey merged commit 693c8b0 into mdn:main Mar 19, 2024
9 checks passed
pepelsbey added a commit to mdn/data that referenced this pull request Mar 19, 2024
@dletorey @pepelsbey
added text-wrap-mode & t-w-style (#720)
2e681ff 
### Description

Added `text-wrap-mode` and `text-wrap-style`

### Motivation

Working on the [Convert text-wrap CSS property to a
shorthand](mdn/content#32341) Issue

### Related issues and pull requests
- [Content PR](mdn/content#32728)
- [BCD PR](mdn/browser-compat-data#22621)
- Firefox Release note PR - coming soon
- [Interactive examples
PR](mdn/interactive-examples#2746)

---------

Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
@dletorey dletorey deleted the 32341-text-wrap branch March 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

@bsmth bsmth Awaiting requested review from bsmth bsmth is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dletorey @pepelsbey