Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32341 text wrap #2746

Merged
merged 5 commits into from
Mar 19, 2024
Merged

32341 text wrap #2746

merged 5 commits into from
Mar 19, 2024

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Mar 12, 2024

Description

Added interactive examples for:

  • text-wrap-style
  • text-wrap-mode

Motivation

Working on the Convert text-wrap CSS property to a shorthand Issue

Related issues and pull requests

@dletorey dletorey requested a review from a team as a code owner March 12, 2024 17:00
@dletorey dletorey requested review from dipikabh and removed request for a team March 12, 2024 17:00
@dipikabh
Copy link
Contributor

Hi @dletorey, thanks for the PR!

I started looking at this, but I didn't find the examples in my local preview at this path "http://127.0.0.1:9090/pages/css/".

I am wondering if you also need to do this step, Updating the metadata, so that the examples get added to the page generator.
So you'd have two entries in this live-examples/css-examples/text/meta.json file for the two new examples.

@dletorey
Copy link
Contributor Author

Hi @dletorey, thanks for the PR!

I started looking at this, but I didn't find the examples in my local preview at this path "http://127.0.0.1:9090/pages/css/".

I am wondering if you also need to do this step, Updating the metadata, so that the examples get added to the page generator. So you'd have two entries in this live-examples/css-examples/text/meta.json file for the two new examples.

I have now added this and yes you are correct.
These 2 urls now work for me, but only in nightly/beta:

@dipikabh
Copy link
Contributor

Thanks, @dletorey, that fixed it.

Yes, based on your BCD PR, I'm testing this in Firefox 124.0b9.

  • text-wrap-mode is looking good ✅
  • text-wrap-style: The pretty option does not seem to be recognized.

interactive example screenshot

The style inspector also does not show pretty as one of the options for text-wrap-style:

screenshot of style inspector

@dletorey
Copy link
Contributor Author

Thanks, @dletorey, that fixed it.

Yes, based on your BCD PR, I'm testing this in Firefox 124.0b9.

* `text-wrap-mode` is looking good ✅

* `text-wrap-style`: The `pretty` option does not seem to be recognized.

interactive example screenshot

The style inspector also does not show pretty as one of the options for text-wrap-style:

screenshot of style inspector

Hi @dipikabh

This is purely due to pretty not yet being supported in Firefox, text-wrap-style is currently only supported in Firefox but further down the line it will be.

text-wrap: pretty; is supported in most chromium based browsers

@dipikabh
Copy link
Contributor

Got it!

In that case, might be a good idea to make text-wrap-style BCD also show support per value, similar to the BCD for text-wrap. Because readers will naturally scroll down to the BCD section after they see the yellow cross.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these examples, @dletorey!

@dipikabh dipikabh merged commit 838dd13 into mdn:main Mar 19, 2024
5 checks passed
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

pepelsbey added a commit to mdn/data that referenced this pull request Mar 19, 2024
### Description

Added `text-wrap-mode` and `text-wrap-style`

### Motivation

Working on the [Convert text-wrap CSS property to a
shorthand](mdn/content#32341) Issue

### Related issues and pull requests
- [Content PR](mdn/content#32728)
- [BCD PR](mdn/browser-compat-data#22621)
- Firefox Release note PR - coming soon
- [Interactive examples
PR](mdn/interactive-examples#2746)

---------

Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
@dletorey dletorey deleted the 32341-text-wrap branch March 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants