Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): new pages for <url> and url() #35486

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix(css): new pages for <url> and url() #35486

merged 1 commit into from
Sep 4, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The <url> is not the same as <url()> anymore. The PR creates a new page for <url> and renames url() page to url_function. The src() hasn't been implemented by any browser yet so haven't created a page for it.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner August 16, 2024 09:54
@OnkarRuikar OnkarRuikar requested review from bsmth and removed request for a team August 16, 2024 09:54
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Aug 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

Preview URLs (35 pages)
Flaws (15)

Note! 27 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/marker-mid
Title: marker-mid
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url_value

URL: /en-US/docs/Web/CSS/marker
Title: marker
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url_value

URL: /en-US/docs/Web/CSS/CSS_Values_and_Units
Title: CSS values and units
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/toggle does not exist

URL: /en-US/docs/Web/CSS/marker-start
Title: marker-start
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url_value

URL: /en-US/docs/Web/CSS/CSS_Types
Title: CSS data types
Flaw count: 7

  • macros:
    • /en-US/docs/Web/CSS/color-stop-list does not exist
    • /en-US/docs/Web/CSS/linear-color-stop does not exist
    • /en-US/docs/Web/CSS/linear-color-hint does not exist
    • /en-US/docs/Web/CSS/ending-shape does not exist
    • /en-US/docs/Web/CSS/size does not exist
    • and 2 more flaws omitted

URL: /en-US/docs/Web/CSS/marker-end
Title: marker-end
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url_value

URL: /en-US/docs/Web/CSS/@counter-style/symbols
Title: symbols
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url_value

URL: /en-US/docs/Web/CSS/CSS_backgrounds_and_borders
Title: CSS backgrounds and borders
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/background-position-inline does not exist
    • /en-US/docs/Web/CSS/background-position-block does not exist

(comment last updated: 2024-09-04 10:44:36)

@OnkarRuikar OnkarRuikar mentioned this pull request Aug 16, 2024
Merged
@Josh-Cena
Copy link
Member

Based on color_value and position_value, I thought we would also have url_value and url instead of url and url_function?

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Aug 17, 2024 •
edited
Loading

Based on color_value and position_value, I thought we would also have url_value and url instead of url and url_function?

Ohh. I found Web/CSS/fit-content vs. Web/CSS/fit-content_function so I mimicked that.

Couple of things here:

  • The color_value and position_value are not accurate because they are types and not literal values. The color_type, position_type, and url_types would be more accurate.
  • The url_function is more descriptive than the plain url. Also, when people search for the term "URL" they should land on <url> page and not on url().
  • In the future, when we document the src() page, it should be named src_function because src is a fairly common term in HTML and APIs.

@OnkarRuikar OnkarRuikar requested review from a team as code owners September 4, 2024 10:43
@OnkarRuikar OnkarRuikar requested review from jpmedley and sideshowbarker and removed request for a team September 4, 2024 10:43
@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:SVG SVG docs labels Sep 4, 2024
@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Sep 4, 2024 •
edited
Loading

As decided, now using the explicit names url_value and url_function for the pages.

@sideshowbarker sideshowbarker merged commit 5178e1e into mdn:main Sep 4, 2024
8 of 9 checks passed
@OnkarRuikar OnkarRuikar deleted the css_url_type branch September 5, 2024 02:35
yin1999 added a commit to mdn/translated-content that referenced this pull request Sep 5, 2024
@yin1999
fix(css): new pages for <url> and url()
e45e887 
ref: mdn/content#35486
yin1999 added a commit to mdn/translated-content that referenced this pull request Sep 5, 2024
@mdn-bot @yin1999
[zh-cn] sync translated content (#23405)
02b1e89 
* zh-cn: sync translated content

* fix(css): new pages for <url> and url()

ref: mdn/content#35486

---------

Co-authored-by: allo <yin199909@aliyun.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@bsmth bsmth Awaiting requested review from bsmth bsmth is a code owner automatically assigned from mdn/yari-content-css

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New <url> and src() pages
3 participants
@OnkarRuikar @Josh-Cena @sideshowbarker