chore(macros): add "except shared" condition to AvailableinWorkers #11888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expect for shared
LeoMcA
changed the title
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… except for shared
Summary
I am adding MDN content that shows a feature is now supported in dedicated and service workers. See mdn/content#36060
Problem
The AvaiIableInWorkers macro does not support the combination of supported in workers except for shared workers.
Solution
I have added an argument option, "window_and_worker_except_shared", which displays text supporting this case.
Screenshots
With the macro call looking like this —
{{AvailableInWorkers("window_and_worker_except_shared")}}— the generated banner now looks like this:How did you test this change?
I included the macro call with my new argument in a test page on mdn/content#36060, set the content repo directory as the source of the content to display in my yari repo env file, and then ran it locally to verify it was working properly.