Fix weird error on global SDK CI from meilisearch/meilisearch #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 677 677
=========================================
Hits 677 677 ☔ View full report in Codecov by Sentry. |
brunoocasali
changed the title
brunoocasali
added
bug
brunoocasali
force-pushed
the
brunoocasali-patch-1
branch
from
80e187e
to
74b8dac
Compare
curquiza
approved these changes
Jul 16, 2024
curquiza
added
maintenance
meili-bors bot
added a commit
that referenced
this pull request
Jul 16, 2024
554: Fix weird error on global SDK CI from meilisearch/meilisearch r=curquiza a=brunoocasali We use to run a global CI with all the SDKs against the nightly build of meilisearch just to spot any potential error during the development phase of the engine team. But this time, the error had nothing to do with their implementation; it only involved the ruby CI. The latest run was breaking in a weird way: https://github.com/meilisearch/meilisearch/actions/runs/9941341341/job/27460158817 Somehow, the `time` gem is explicitly required before using some methods like `Time.parse`. I say it is weird because we have the same configuration in this repo, and we don't have that error. CC: `@ellnix` `@curquiza` Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
|
Build failed: |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Jul 16, 2024
554: Fix weird error on global SDK CI from meilisearch/meilisearch r=curquiza a=brunoocasali We use to run a global CI with all the SDKs against the nightly build of meilisearch just to spot any potential error during the development phase of the engine team. But this time, the error had nothing to do with their implementation; it only involved the ruby CI. The latest run was breaking in a weird way: https://github.com/meilisearch/meilisearch/actions/runs/9941341341/job/27460158817 Somehow, the `time` gem is explicitly required before using some methods like `Time.parse`. I say it is weird because we have the same configuration in this repo, and we don't have that error. CC: `@ellnix` `@curquiza` Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use to run a global CI with all the SDKs against the nightly build of meilisearch just to spot any potential error during the development phase of the engine team.
But this time, the error had nothing to do with their implementation; it only involved the ruby CI. The latest run was breaking in a weird way: https://github.com/meilisearch/meilisearch/actions/runs/9941341341/job/27460158817
Somehow, the
timegem is explicitly required before using some methods likeTime.parse. I say it is weird because we have the same configuration in this repo, and we don't have that error.CC: @ellnix @curquiza