Add missing add_ function examples #192 #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackwinter
approved these changes
Jul 31, 2025
Member
blackwinter
left a comment
blackwinter
left a comment
There was a problem hiding this comment.
The examples for add_array and add_hash don't show their respective behaviour with regard to the presence/absence of intermediate fields. I think it would make sense that add_* and set_* should match each other. But I'm fine either way.
Contributor
Author
|
@blackwinter I updated the examples to match the new one from #227 Could you have a look? |
blackwinter
requested changes
Dec 17, 2025
Member
blackwinter
left a comment
blackwinter
left a comment
There was a problem hiding this comment.
The add_array example shows the use of set_array. The add_hash example mixes both add_hash and set_hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #192
This can be merged right away these examples are missing in the playground.