Add and update set_ function examples #192 #227
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You should reset your branch. It also includes the changes from #226. |
blackwinter
approved these changes
Jul 31, 2025
Member
blackwinter
left a comment
blackwinter
left a comment
There was a problem hiding this comment.
Apart from the branch mishap, 👍.
TobiasNx
force-pushed
the
192-addSetFunctions
branch
from
c2dc17d to
e812323
Compare
Contributor
Author
|
@blackwinter I have reset the branch to exclude the àdd_ |
blackwinter
approved these changes
Dec 17, 2025
Member
blackwinter
left a comment
blackwinter
left a comment
There was a problem hiding this comment.
Inconsistent wording "is missing" vs. "is not provided", but negligible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to metafacture/metafacture-core#704
These should be the new and adjusted examples in the playground for the set_ functions.
@blackwinter do you think the set_ function examples are good enough?