-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ODOO-414][ADD] Added new view description to control panel area #20
[ODOO-414][ADD] Added new view description to control panel area #20
Conversation
@amh-mw Travis reminded me that I should had made the metricwise_add_report_description.mp4 |
f1a0152
to
3ebff71
Compare
@amh-mw PR is down to 1 commit now |
This doesn't seem to want to patch with either -p1 or -p2. This is an unfortunate side effect of how Odoo changes the file hierarchy on disk as part of the Python packaging process. The "easy" fix would be to break this into two pull requests and patch one each way, but... 🤮 Let me think about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after carefully reviewing the patch -p1 output, I think the best course of action is to take the server side changes to ir.actions and move them into a separate odoo-metricwise pull requests -- see my untested ODOO-414 branch for a head start.
Just as a heads up, I am working up a new patching modality that may solve this without any changes. Stay tuned. |
Sorry I was really busy. |
Ok, so the latest develop I just pushed adds a new To test your patch, you can basically extract
And then |
@amh-mw The file was added correctly but I can't get past the |
I believe Mac uses a slightly different version of |
I can't say that I have ever used any unix flavor that didn't have sed. It's been around since 1973. 😁 Centos 6:
Debian 11:
|
Ah... so the issue is that your flavor of sed doesn't have -E for ERE? I'll just have to rewrite the pattern as BRE. |
I've force pushed a BRE-compatible script to develop. Could you type |
Yes, I get |
Try the new patterns?
|
Still nothing |
What flavor of unix are you running? Maybe I can stand up a container to try and reproduce? |
Linux 5.15.0-46-generic |
So you do have access to ERE. Maybe that's not the problem. Is your source code volume mounted read-only? |
No, it's not |
@amh-mw is there anything else I can to do to help here? |
@amh-mw we managed it. It ran successfully. original: We removed the silent flag from the Both test and run were successful. Is there anything else we can do? |
You should create a pull request against odoo-metricwise, now that your patch has been copied into the docker/odoo/patches folder. |
3ebff71
to
e9fa865
Compare
e9fa865
to
9c52041
Compare
@Jessica-BlueStingray I think Adam is referring to a new PR in the other repo, similar to Dylan's on MetricWise/odoo-metricwise#8 |
Like this? : Metricwise#11 |
Moved into #27. |
Add report description
This update adds a description area and
view_description
field to the Control Panel between the name and the Search Area.To test:
Upgrade the modules
Turn on debug mode
Click on the debug button > Edit Action > Add a text to
view_description
> Save > Refresh page.