Skip to content

Comments

18Korea#78

Merged
mg merged 10 commits intomg:masterfrom
j-holub:18Korea
Dec 14, 2025
Merged

18Korea#78
mg merged 10 commits intomg:masterfrom
j-holub:18Korea

Conversation

@j-holub
Copy link
Contributor

@j-holub j-holub commented Nov 4, 2025

18Korea

BGG: 18Korea
Rules: English Rulebook

A friend asked me to add this one to your app, I neither own the game nor have I played it, I scraped all the information from the rulebook and photos of the game on BGG.

As last time, I have a couple of questions, sorry for the trouble:

  • From what I've gathered, this game does not seem to have traditional private companies, it has something called "Assets", but If I look at the Asset Print Sheet somebody posted on BGG, these look like they just give companies special abilities but there's not worth tied to them. I assume I don't need to add them?
  • If I understood it correctly, there's no bank pool limit. I've put a 1 as in 100% for bank pool, is that correct?
  • If buying from the bank pool, players are allowed to buy over the usual 60% share limit of a company. Does this mean I should also add values of 0.7 and above to ownership? Other games like 1889 allow to hold more than 60% if the company is within the brown area of the stock market but I don't see any values above 0.6 in the ownership field of 1889.

A small note, if you use a squash merge to merge the PR, all the commits in the PR will be squashed into one commit that's merged into your main branch, then you don't have all the small commits from the branch (unless you actually want them). My workflow is usually to commit it small steps in the PRs and then squash merge it into main/master such that the history is cleaner and you can also revert it easily, in case it did break something.

As always, thank you so much for what you did with that app, it's such a lifesaver when playing 18XX titles.

@mg
Copy link
Owner

mg commented Nov 6, 2025

Nice!

"From what I've gathered, this game does not seem to have traditional private companies, it has something called "Assets", but If I look at the Asset Print Sheet somebody posted on BGG, these look like they just give companies special abilities but there's not worth tied to them. I assume I don't need to add them?"
Correct.

"If I understood it correctly, there's no bank pool limit. I've put a 1 as in 100% for bank pool, is that correct?"
Correct. So the president share can end up in the bank pool?

"f buying from the bank pool, players are allowed to buy over the usual 60% share limit of a company. Does this mean I should also add values of 0.7 and above to ownership? Other games like 1889 allow to hold more than 60% if the company is within the brown area of the stock market but I don't see any values above 0.6 in the ownership field of 1889."
1889 specifies above 60% ownership in the corporate structure field:


Look at how the revenue calculator 1889 looks in the app, it renders an "Exceptional" table for the payouts. The result caluclator will then allow for 100% ownership of a company for end of game calculations.

@j-holub
Copy link
Contributor Author

j-holub commented Nov 18, 2025

Sorry for the late reply, I'm not spending so much time on my private laptop anymore these days. I have added pretty much exactly what you've added for 1889, except that I changed the bank pool size to 1, as according to the rules there's no limit for the bank pool.

At this point I'm not really familiar with that these values do, I've looked at how it looks for 1889 in the app and I guess that's about correct. If I'll ever have some corrections, I'll send them your way.

With that, this PR is ready to merge from my side.

@mg
Copy link
Owner

mg commented Nov 19, 2025

hi, are there no par values or floating thresholds for companies?

Simulator Screenshot - iPhone 16 Pro Max - 2025-11-19 at 21 18 33

@j-holub
Copy link
Contributor Author

j-holub commented Nov 20, 2025

As far as I understand from reading the rulebook, you can give up a company for auction to start it, so there's nothing like par values or number of shares needed to be sold to float the company.

You can auction director's certificate of a company that has not been founded on your turn. The scope of companies that can be auctioned varies depending on whether the Korean War has occurred or not. Before the outbreak of the Korean War, only companies excluding the bottom row of IPOs could be auctioned off. (Red Cube Company) If the Korean War broke out, you could auction all but the North Korean Railway Company (top row from the IPO). The auction starts at O won and proceeds in increments of 5 Won. You don't have to start with O Won and you can increase the price a lot in one go. The auction proceeds in turn order until a winner is announced. If you pass your turn in an auction, you will not be able to participate again in that auction. The winner of the auction pays the winning bid to the bank and gets a company dashboard and director's certificate. At this point, you can sell as many shares as you want.

  • Even if you don't have the cash to pay the
    winning bid, you can still pay by selling the
    stock.
  • Company is established after the auction.

After setting the price of the company, you put in the company from your own personal money at twice the price of that stock. A token is placed at the price you set on the stock track. If there is already another company's token at that price, place the company's token on the rightmost of that space. A token is placed on the profit track. The rest of the tokens are placed.on the company dashboard. The remaining shares of the company (10% shares) are placed on the company dashboard. Take the cube (red or blue) from the company's starting city and place it on the top right of the company dashboard.

@mg
Copy link
Owner

mg commented Nov 20, 2025

Crazy game designer. Alright, thanks!

@j-holub
Copy link
Contributor Author

j-holub commented Nov 20, 2025

I guess it's technically 20% to float, as you auction off a president certificate. Depending on the initial price (par price) you wanna go for, you need double that in cash (the way I read it, is the you have to pay the winning price of the auction + double the share value).

So in theory, you could set percent to float to 0.2 and list all the possible values you can set the initial value of the company as.

Let me ask my friend who played the game already real quick.

@j-holub
Copy link
Contributor Author

j-holub commented Nov 20, 2025

Okay I got some confirmation.

There is a range for the initial Stock Value that you can choose, but the rulebook does not mention this when explaining this tock round auctions, but only at the end in the Appendix 🙄 Writing rules is an art form of its own I guess.

The range is 60-100 before the Korean War and 60-200 after. I suppose the app does not have a feature for changes like these, so I would just add 60-200 as the par values, with 20% to float.

It's true, that you have to pay the winning price of the auction into the bank, plus twice the initial par value into the company, but I think par + percent to float is enough to help players to figure out how much they can spend on the auction at most.

Thanks for being thorough with that, it's hard to add files for a game that I haven't played myself (and maybe even never will), my friend just asked me if I could cause he doesn't know how to do it.

I'll make the necessary changes later.

@j-holub
Copy link
Contributor Author

j-holub commented Nov 20, 2025

Everything's added, unless there's a way make a toggle to switch between pre- and post-Korean War par values.

Nothing else to add from my side I think.

@j-holub
Copy link
Contributor Author

j-holub commented Nov 21, 2025

In the PR for 1828 (#18) I saw that you use something called exceptional ownership, isn't that a much simpler way to include the ability to own more than 60% of a company?

exceptional ownership: 0.7, 0.8, 0.9, 1

@mg
Copy link
Owner

mg commented Nov 25, 2025

The exceptional ownership was a first implementation of this functionality. When I built the corporate structure api to support other more complex 18xx features, I removed this api because the corporate structure api provided what I needed.

@j-holub
Copy link
Contributor Author

j-holub commented Nov 25, 2025

All right, then I think this one is ready to merge : )

@mg mg merged commit 1951af8 into mg:master Dec 14, 2025
@mg
Copy link
Owner

mg commented Dec 14, 2025

ty for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants