Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help documentation and docstrings #29

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Add help documentation and docstrings #29

merged 16 commits into from
Dec 18, 2024

Conversation

microbit-robert
Copy link
Collaborator

@microbit-robert microbit-robert commented Dec 12, 2024

No description provided.

```

```package
machine-learning=github:microbit-foundation/pxt-microbit-ml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this should in some way be versioned? Might be awkward or something we can revisit after getting this documentation out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awkward. This can be versioned, and probably should be versioned. However, what version should it reference. Ideally a future version that we haven't tagged yet, otherwise it's always slightly out of sync.

We might have to merge changes as they are, tag, commit a change to set this to the most recently tagged version, then tag again?

Scenarios where versioning is important:
If we remove a block, it's example or signature will no longer render in the help docs for older versions of the extension.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target most recently tagged version for now 69336c5. There haven't been any relevant block changes since this tag so this should be safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that ideally this would be templated and happen during "pxt bump" but not clear there's a mechanism to do this. One to revisit when we need to tag a version that doesn't exist!

@microbit-robert microbit-robert marked this pull request as ready for review December 18, 2024 09:49
@microbit-robert microbit-robert merged commit 838fbc6 into main Dec 18, 2024
2 checks passed
@microbit-robert microbit-robert deleted the docs branch December 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants