Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help documentation and docstrings #29
Add help documentation and docstrings #29
Changes from 5 commits
18a60c6
341d104
1eb3c4f
840d30e
63d787c
6b03f6a
c54d903
69336c5
9f629a9
8d21e61
b1e10db
4ccb8af
98c09f0
82076b8
8f5502e
831fdd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this should in some way be versioned? Might be awkward or something we can revisit after getting this documentation out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awkward. This can be versioned, and probably should be versioned. However, what version should it reference. Ideally a future version that we haven't tagged yet, otherwise it's always slightly out of sync.
We might have to merge changes as they are, tag, commit a change to set this to the most recently tagged version, then tag again?
Scenarios where versioning is important:
If we remove a block, it's example or signature will no longer render in the help docs for older versions of the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Target most recently tagged version for now 69336c5. There haven't been any relevant block changes since this tag so this should be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that ideally this would be templated and happen during "pxt bump" but not clear there's a mechanism to do this. One to revisit when we need to tag a version that doesn't exist!