Automation: main-next integrate #16609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures we won't fail the pipeline if the bundle comparison task fails: https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/steps-task?view=azure-pipelines --------- Co-authored-by: Tony Murphy <anthonm@microsoft.com>
## Description This PR adds more complex move tests to the file `editing.spec.ts` Co-authored-by: Yann Achard <achardy@microsoft.com>
…data store (#16578) ## Description `SharedDirectory` was using `-1` all the time for locally created subdirectories. This leads to bugs when considering the logic in `isMessageForCurrentInstanceOfSubDirectory` when the `SharedDirectory` is additionally detached: no ack op will ever be received for that subdir (since an op is never sent), but clients who load using the attachment summary may start sending ops which refers to the same subdirectory. merge-tree has a similar problem which is resolved by using `-1` or `0` depending on the attach state of the DDS, see `UnassignedSequenceNumber` vs `UniversalSequenceNumber`. The fix here brings SharedDirectory handling closer to merge-tree's.
⯅ @fluid-example/bundle-size-tests: +70 Bytes
Baseline commit: b20a44c |
sonalideshpandemsft
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-lease