Fix environment card text colors for high contrast users #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er design guidance
bbonaby
requested review from
dhoehna,
jsidewhite,
huzaifa-d,
vineeththomasalex,
safmswork,
krschau,
sshilov7 and
SohamDas2021
bbonaby
commented
Sep 9, 2024
| @@ -145,13 +145,13 @@ | |||
| VerticalAlignment="Center"> | |||
| <TextBlock | |||
| Text="{x:Bind DisplayName, Mode=OneWay}" | |||
| Foreground="{ThemeResource TextFillColorSecondaryBrush}" | |||
| Foreground="{ThemeResource TextFillColorPrimaryBrush}" | |||
| Margin=" 0 0 0 0" | |||
There was a problem hiding this comment.
This one was originally a secondary color but I'm changing it to be primary like the textblock below it. They both should have been the same color.
This line represents the "Microsoft Dev Box" text in the image below:
krschau
approved these changes
Sep 9, 2024
I created an issue for them here: #3809 . Will link the PR to that issue |
huzaifa-d
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Currently there a couple places on the environment pages where we use the
TextFillColorTertiaryBrushWin UI color brush. However, this brush does not provide a good enough contrast ratio when used in high contrast mode. This is an accessibility issue. Looking at the Win UI gallery guidance, we should actually be using theTextFillColorPrimaryBrushfor text that is at rest (See Win UI gallery apps color section for text). This PR updates these usages ofTextFillColorTertiaryBrushtoTextFillColorPrimaryBrush.Before:
Before - setup environments page
Before - environments page
After:
After - setup environments page
After changes - environments page
References and relevant issues
Accessibility internal bugs:
https://task.ms/49714932
https://task.ms/50453683
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist