Really fix Dashboard crash when widgets runtime isn't present #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
guimafelipe,
dkbennett,
andreww-msft,
EricJohnson327 and
lauren-ciha
guimafelipe
approved these changes
Sep 10, 2024
bbonaby
approved these changes
Sep 10, 2024
tools/Dashboard/DevHome.Dashboard/Services/WidgetServiceService.cs
Outdated
Show resolved
Hide resolved
tools/Dashboard/DevHome.Dashboard/Services/WidgetServiceService.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
#3819 wasn't a sufficient fix because we were still calling .First() on a potentially empty list. Instead, check if there's anything in the list and return null if there isn't.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist