Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really fix Dashboard crash when widgets runtime isn't present #3828

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Really fix Dashboard crash when widgets runtime isn't present #3828

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed2bfd5
Explicitly check if we have a package to return
krschau Sep 10, 2024
060bcb9
first or default
krschau Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions tools/Dashboard/DevHome.Dashboard/Services/WidgetServiceService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,26 @@ private Package GetWebExperiencePackPackage()
WidgetHelpers.WebExperiencePackageFamilyName,
(minSupportedVersion400, version500),
(minSupportedVersion500, null));
return packages.First();

if (packages.Any())
{
return packages.First();
}

return null;
krschau marked this conversation as resolved.
Show resolved Hide resolved
}

private Package GetWidgetsPlatformRuntimePackage()
{
var minSupportedVersion = new Version(1, 0, 0, 0);

var packages = _packageDeploymentService.FindPackagesForCurrentUser(WidgetHelpers.WidgetsPlatformRuntimePackageFamilyName, (minSupportedVersion, null));
return packages.First();
if (packages.Any())
{
return packages.First();
}

return null;
krschau marked this conversation as resolved.
Show resolved Hide resolved
}

private WidgetServiceStates ValidatePackage(Package package)
Expand Down
Loading