-
Notifications
You must be signed in to change notification settings - Fork 340
[main] Update dependencies from dotnet/arcade #15264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
92a9bb2
2405153
8a1ae15
78837d0
7f04efa
f7e84c7
123e963
7bae699
5d52227
b3eaed8
50a5de2
7761d54
8da8bb8
eb17490
4aaf635
98f5431
a3df210
619f71a
81e90a5
e6e7b0a
189bd4a
c39ccc2
daea8f2
b5bda66
da8f639
1015148
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,7 +81,7 @@ stages: | |
| timeoutInMinutes: 120 | ||
| pool: | ||
| name: NetCore-Public | ||
| demands: ImageOverride -equals windows.vs2022preview.amd64.open | ||
| demands: ImageOverride -equals windows.vs2026preview.scout.amd64.open | ||
| strategy: | ||
| matrix: | ||
| Release: | ||
|
|
@@ -115,6 +115,8 @@ stages: | |
| /bl:$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Test.binlog | ||
| name: Test | ||
| displayName: Test | ||
| env: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. I'm curious why it's needed now but was working earlier?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #15329 maybe it is not needed let's see |
||
| DOTNET_ROOT: $(Build.SourcesDirectory)/.dotnet | ||
|
|
||
| # This step is only helpful for diagnosing some issues with vstest/test host that would not appear | ||
| # through the console or trx | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| @echo off | ||
| powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0eng\common\Build.ps1""" -restore -build %*" | ||
| powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0eng\Build.ps1""" -restore -build %*" | ||
| exit /b %ErrorLevel% |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| [CmdletBinding(PositionalBinding=$false)] | ||
| Param( | ||
| [string][Alias('c')]$configuration = "Debug", | ||
| [string]$platform = $null, | ||
| [string] $projects, | ||
| [string][Alias('v')]$verbosity = "minimal", | ||
| [string] $msbuildEngine = $null, | ||
| [bool] $warnAsError = $true, | ||
| [bool] $nodeReuse = $true, | ||
| [switch] $buildCheck = $false, | ||
| [switch][Alias('r')]$restore, | ||
| [switch] $deployDeps, | ||
| [switch][Alias('b')]$build, | ||
| [switch] $rebuild, | ||
| [switch] $deploy, | ||
| [switch][Alias('t')]$test, | ||
| [switch] $integrationTest, | ||
| [switch] $performanceTest, | ||
| [switch] $sign, | ||
| [switch] $pack, | ||
| [switch] $publish, | ||
| [switch] $clean, | ||
| [switch][Alias('pb')]$productBuild, | ||
| [switch]$fromVMR, | ||
| [switch][Alias('bl')]$binaryLog, | ||
| [switch][Alias('nobl')]$excludeCIBinarylog, | ||
| [switch] $ci, | ||
| [switch] $prepareMachine, | ||
| [string] $runtimeSourceFeed = '', | ||
| [string] $runtimeSourceFeedKey = '', | ||
| [switch] $excludePrereleaseVS, | ||
| [switch] $nativeToolsOnMachine, | ||
| [switch] $help, | ||
| [Parameter(ValueFromRemainingArguments=$true)][String[]]$properties | ||
| ) | ||
|
|
||
| # Workaround for DOTNET_HOST_PATH not being set by older MSBuild | ||
| if (-not $env:DOTNET_HOST_PATH) { | ||
| $env:DOTNET_HOST_PATH = [System.IO.Path]::GetFullPath((Join-Path (Join-Path (Join-Path $PSScriptRoot '..') '.dotnet') 'dotnet')) | ||
| if (-not (Test-Path $env:DOTNET_HOST_PATH)) { | ||
| $env:DOTNET_HOST_PATH = "$($env:DOTNET_HOST_PATH).exe" | ||
| } | ||
| } | ||
|
Comment on lines
+37
to
+43
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This workaround shouldn't be needed when using vs2026. Can you try reverting please?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #15328 yeah I noticed that as well, but did not want to wait for whole another build. |
||
|
|
||
| & $PSScriptRoot/common/build.ps1 @PSBoundParameters | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We needed this in testfx when we moved from VSTest to MTP because we are now running a standalone executable, but why would an arcade update need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#15329 maybe it is not needed let's see