Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB-2554 Add integration tests (Cypress / wiremock) for GOV.UK One Login #21

Merged
merged 6 commits into from
Sep 25, 2023
Merged

VB-2554 Add integration tests (Cypress / wiremock) for GOV.UK One Login #21

merged 6 commits into from
Sep 25, 2023

Conversation

tpmcgowan
Copy link
Contributor

@tpmcgowan tpmcgowan commented Sep 21, 2023 •
edited
Loading

  • Add integration tests for GOV.UK One Login, to ensure the correct flow is followed (documented here).
  • Customisations to NPM scripts to set up the environment for testing (mocking OIDC discovery endpoint and setting test private key)
  • Various tweaks to get build working in CircleCI

@tpmcgowan
Mock discovery endpoint and set test private key on startup
a5f8bce
@tpmcgowan
Tweaks to OIDC settings
0c1538a 
* Not using PKSE
* Pass nonce to both passport.authenticate() calls
* No need to explicitly set 'state'; openid-client adds it
@tpmcgowan
Remove unnecessary import in appSetup.ts
b6a744f
@tpmcgowan
Add integration tests for GOV.UK One Login
12aeab0
@tpmcgowan tpmcgowan force-pushed the vb-2554-govuk-one-login-integration-tests branch from d615b70 to 12aeab0 Compare September 21, 2023 20:49
@tpmcgowan tpmcgowan force-pushed the vb-2554-govuk-one-login-integration-tests branch from e239d24 to 8d1f153 Compare September 22, 2023 11:24
tpmcgowan
tpmcgowan commented Sep 22, 2023
View reviewed changes
package.json Show resolved Hide resolved
@tpmcgowan tpmcgowan marked this pull request as ready for review September 22, 2023 12:52
psoleckimoj
psoleckimoj previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@psoleckimoj psoleckimoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

psoleckimoj
psoleckimoj approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@psoleckimoj psoleckimoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tpmcgowan tpmcgowan merged commit 4894b50 into main Sep 25, 2023
@tpmcgowan tpmcgowan deleted the vb-2554-govuk-one-login-integration-tests branch September 25, 2023 11:00
This was referenced Sep 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psoleckimoj psoleckimoj psoleckimoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpmcgowan @psoleckimoj