Skip to content

Commit

Permalink
Fix [Feature Store] Capitalize the first letter of the sentence in th…
Browse files Browse the repository at this point in the history
…e Schema description.
  • Loading branch information
ilan7empest committed Nov 17, 2023
1 parent 2f6fc03 commit bbcf9ef
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ const FeatureSetsPanelSchemaView = ({
<FeatureSetsPanelSection title="Schema">
<div className="schema__description">
<span>
Each feature set must be associated with one or more index column.
when joining feature sets the entity is used as the key column.
Each feature set must be associated with one or more index column. When joining feature
sets, the entity is used as the key column.
</span>
<span>
<a
className="link"
href="https://docs.mlrun.org/en/latest/feature-store/feature-sets.html"
Expand Down Expand Up @@ -75,14 +77,9 @@ const FeatureSetsPanelSchemaView = ({
floatingLabel
invalid={!validation.isTimestampKeyValid}
label="Timestamp key"
onChange={timestamp_key =>
setData(state => ({ ...state, timestamp_key }))
}
onChange={timestamp_key => setData(state => ({ ...state, timestamp_key }))}
onBlur={event => {
if (
featureStore.newFeatureSet.spec.timestamp_key !==
event.target.value
) {
if (featureStore.newFeatureSet.spec.timestamp_key !== event.target.value) {
setNewFeatureSetSchemaTimestampKey(event.target.value)
}
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@

&__description {
margin-bottom: 10px;

& > *:first-child {
margin-right: 5px;
}
}
}

0 comments on commit bbcf9ef

Please sign in to comment.