fix(gridintersect): clean up of gridintersect #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wpbonelli
requested changes
Oct 23, 2024
There was a problem hiding this comment.
I think the next release will probably be 3.9 to coincide with mf6.6 next month? Per the documented deprecation policy we should then wait 2 minor releases before removing but IMO deprecating in 3.9 and dropping in 3.10 is fine — minor releases may slow down as development effort shifts toward the next major version
|
There will probably be a merge conflict for this PR once #2343 is merged, I'll fix it when that happens. |
wpbonelli
approved these changes
Oct 23, 2024
langevin-usgs
approved these changes
Oct 23, 2024
|
If we are requiring |
Good spot. Done! |
- axis equal - relim axes for polygons - allow result to be geodataframe - add plot_intersection_result() method
- deactivate above/inside tests with TODO
- make sure every aspect of previous test suite is maintained
change version numbers to reflect release schedule
wpbonelli
force-pushed
the
fix_2344_refactor_gridintersect
branch
from
9ee002b
to
9ba6cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
method != "vertex"method="structured"is officially removedNote:
method="vertex". Will probably be added in a separate PR.I'm not sure what the next release will be so I marked most things deprecated (with warning) in the next release and to be removed by 3.10.0. Let me know if that makes sense.
EDIT: modify removal version to 3.10.0