Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gridintersect): clean up of gridintersect #2346

Merged
merged 25 commits into from
Oct 24, 2024
Merged

fix(gridintersect): clean up of gridintersect #2346

merged 25 commits into from
Oct 24, 2024

Commits on Oct 24, 2024

  1. add deprecation warning when method!="vertex"

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7d01f9e View commit details
    Browse the repository at this point in the history

  2. add todos and docstring deprecations for structured code

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e63a9b6 View commit details
    Browse the repository at this point in the history

  3. remove shapely<2.0 stuff

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b07b638 View commit details
    Browse the repository at this point in the history

  4. add option to return as DataFrame

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    54d7ba1 View commit details
    Browse the repository at this point in the history

  5. add option to return intersection result as GeoDataFrame

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    531d5c4 View commit details
    Browse the repository at this point in the history

  6. remove shapely<2.0 stuff

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    02e52b2 View commit details
    Browse the repository at this point in the history

  7. cleanup deprecated methods

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    745d0ae View commit details
    Browse the repository at this point in the history

  8. remove shapely<2.0 stuff

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f215f5f View commit details
    Browse the repository at this point in the history

  9. clean up imports

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    195a8bf View commit details
    Browse the repository at this point in the history

  10. update docstring

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    360559b View commit details
    Browse the repository at this point in the history

  11. improve plotting 

    - axis equal
- relim axes for polygons
- allow result to be geodataframe
- add plot_intersection_result() method
    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    01329a2 View commit details
    Browse the repository at this point in the history

  12. some final fixes

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3520391 View commit details
    Browse the repository at this point in the history

  13. use GeometryType Enum

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6dfa954 View commit details
    Browse the repository at this point in the history

  14. move raster tests to separate file

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    167bfc9 View commit details
    Browse the repository at this point in the history

  15. move raster tests to separate file

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6803dea View commit details
    Browse the repository at this point in the history

  16. clean up imports

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5e5f176 View commit details
    Browse the repository at this point in the history

  17. add notes for tests to be removed

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c549381 View commit details
    Browse the repository at this point in the history

  18. update 3d tests with method vertex 

    - deactivate above/inside tests with TODO
    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a1f0f42 View commit details
    Browse the repository at this point in the history

  19. add/modify tests to use method="vertex" 

    - make sure every aspect of previous test suite is maintained
    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    513a457 View commit details
    Browse the repository at this point in the history

  20. update/improve notebook

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a0ca767 View commit details
    Browse the repository at this point in the history

  21. add docstring

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    117169e View commit details
    Browse the repository at this point in the history

  22. ruff

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    59ffe2e View commit details
    Browse the repository at this point in the history

  23. add warning for shapely2 kwarg 

    change version numbers to reflect release schedule
    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4ebd2a0 View commit details
    Browse the repository at this point in the history

  24. change version numbers to reflect release schedule

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    24d4597 View commit details
    Browse the repository at this point in the history

  25. update shapely minimum version

    @dbrakenhoff @wpbonelli
    dbrakenhoff authored and wpbonelli committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9ba6cc2 View commit details
    Browse the repository at this point in the history