This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Fix ambiguous default export #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawaru
force-pushed
the
fix/bad-default-export-bad
branch
from
91ffda3
to
5508799
Compare
|
What's the reasoning behind this PR? |
|
Updated the PR description to include reason for this change, will resolve the conflict later. |
triphora
approved these changes
Nov 12, 2023
Geometrically
approved these changes
Nov 13, 2023
|
merge conflict pls fix |
Currently Omorphia's index file has both the default and named exports. While this is totally supported by native ESM, it's pretty hard for transpilers to process and may lead to situations where named exports cannot be imported directly, requiring destructuring on the default import. For this and just consistency reasons, you'd usually avoid mixing default and named exports. This commit removes the default export, making it just an another named export called `plugin`. BREAKING CHANGE: plugin is now exported using `plugin` export, rather than the default export.
brawaru
force-pushed
the
fix/bad-default-export-bad
branch
from
5508799
to
fe36c18
Compare
|
Rebased 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Omorphia's index file has both the default and named exports. While this is totally supported by native ESM, it's pretty hard for transpilers to process and may lead to situations where named exports cannot be imported directly, requiring destructuring on the default import. For this and just consistency reasons, you'd usually avoid mixing default and named exports.
This PR removes the default export, making it just an another named export called
plugin.BREAKING CHANGE: plugin is now exported using
pluginexport, rather than the default export.