Open
Conversation
Contributor
Author
|
@Mark-H I don't know if you are responding from your provider differently. I noticed at least one extra that was empty, so I assume it's not using the weird method the GetList processor is expecting. |
opengeek
changed the title
| foreach ($metadata as $row) { | ||
| if (!empty($row['name']) && $row['name'] === 'description') { | ||
| $packageArray['readme'] = nl2br($row['text']); | ||
| foreach ($metadata as $k => $v) { |
Contributor
There was a problem hiding this comment.
Even although it might be obvious what the variables mean I would still prefer them to be a bit more descriptive.
Collaborator
There was a problem hiding this comment.
$k/$v -> $metaKey/$metaValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adjust Processors\Workspace\Packages\GetList class's function getPackageMeta
Why is it needed?
At some point in the last 14-17 years, the provider started responding with a different model than what was expected. Rather than changing the provider and potentially breaking a lot more areas that work with the metadata field, I propose to change the processor.
How to test
Open your package management page
/manager/?a=workspacesand try to expand an extra that was installed with the provider. It will expose an empty field.Related issue(s)/PR(s)
This was pointed out in Community Slack