Skip to content

Fix package metadata format #16911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matdave wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Fix package metadata format #16911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/Revolution/Processors/Workspace/Packages/GetList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ public function getPackageMeta(modTransportPackage $package, array $packageArray
{
$metadata = $packageArray['metadata'];
if (!empty($metadata)) {
foreach ($metadata as $row) {
if (!empty($row['name']) && $row['name'] === 'description') {
$packageArray['readme'] = nl2br($row['text']);
foreach ($metadata as $k => $v) {
Copy link
Contributor

@JoshuaLuckers JoshuaLuckers Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even although it might be obvious what the variables mean I would still prefer them to be a bit more descriptive.

Copy link
Collaborator

@Ibochkarev Ibochkarev Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$k/$v -> $metaKey/$metaValue

if ($k === 'description') {
$packageArray['readme'] = nl2br($v);
break;
}
}
Expand Down