Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #557

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Develop #557

merged 10 commits into from
Nov 22, 2024

Conversation

natashapinto
Copy link
Collaborator

@natashapinto natashapinto commented Nov 22, 2024

  • Updated mokapipe workflow ID and pipeline ID
  • ED VCP3 panel of normals Rdata file updated
  • Test emails redirected to mokaguys
  • Run the docker images as the mokaguys user instead of root. This means that the files created are owned by mokaguys too, making them easier to delete with the workstation cleaner- currently this is failing because of user permissions issues

This change is Reviewable

Copy link
Contributor

@rebeccahaines1 rebeccahaines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @natashapinto)


config/ad_config.py line 40 at r1 (raw file):

if BRANCH == "main" and "pytest" not in sys.modules:  # Prod branch
    TESTING = True  # Set testing mode

testing is wrong again- should be false here
Sorry think I must have missed this in the previous PR


config/ad_config.py line 59 at r1 (raw file):

    }
else:  # Testing branch
    TESTING = False

testing wrong- true
Sorry think I must have missed this in the previous PR

Copy link
Collaborator Author

@natashapinto natashapinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @rebeccahaines1)


config/ad_config.py line 40 at r1 (raw file):

Previously, rebeccahaines1 wrote…

testing is wrong again- should be false here
Sorry think I must have missed this in the previous PR

Sorry fixed now


config/ad_config.py line 59 at r1 (raw file):

Previously, rebeccahaines1 wrote…

testing wrong- true
Sorry think I must have missed this in the previous PR

Sorry fixed now

Copy link
Contributor

@rebeccahaines1 rebeccahaines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @natashapinto)

@rebeccahaines1 rebeccahaines1 merged commit 1121968 into main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants