-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #557
Develop #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @natashapinto)
config/ad_config.py
line 40 at r1 (raw file):
if BRANCH == "main" and "pytest" not in sys.modules: # Prod branch TESTING = True # Set testing mode
testing is wrong again- should be false here
Sorry think I must have missed this in the previous PR
config/ad_config.py
line 59 at r1 (raw file):
} else: # Testing branch TESTING = False
testing wrong- true
Sorry think I must have missed this in the previous PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @rebeccahaines1)
config/ad_config.py
line 40 at r1 (raw file):
Previously, rebeccahaines1 wrote…
testing is wrong again- should be false here
Sorry think I must have missed this in the previous PR
Sorry fixed now
config/ad_config.py
line 59 at r1 (raw file):
Previously, rebeccahaines1 wrote…
testing wrong- true
Sorry think I must have missed this in the previous PR
Sorry fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @natashapinto)
This change is