Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Monorepo style #1947

Closed
wants to merge 48 commits into from
Closed

chore: Monorepo style #1947

wants to merge 48 commits into from

Conversation

shaharzil
Copy link
Contributor

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component is written in TypeScript.

Style

  • Styles are added to NewComponent.modules.scss file inside the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.
  • Styles are defined using monday-ui-style tokens
  • Displays correctly in all the themes

Storybook

  • Stories were added to /src/components/NewComponent/__stories__/NewComponent.mdx file.
  • Stories include all flows of using the component.
  • Stories implemented using vibe-storybook-components components and tokens.

Tests

Accessibility

Daniel Mittelman and others added 30 commits February 12, 2024 18:44
@shaharzil
Initial commit
1f0657d
@shaharzil
Update README.md
1040d68
@shaharzil
Committed hidden files which were missing during initial migration
b4fc826
@shaharzil
Create npm-publish.yml
cefef5e
@shaharzil
Updated package.json to the new package's name and version
ab6caa6
@shaharzil
Fixed GitHub actions
60f70b0
@shaharzil
Added an install step to GitHub Actions
33638ec
@shaharzil
Bumped version to 0.0.4
31f7a59
@vladmonday @shaharzil
doc: change urls to the new repository
5fedc49
@vladmonday @shaharzil
doc: change url to the new repo in package.json
8f4139f
@orrgottlieb @shaharzil
feat: Icons initial commit
1d0e56e
@orrgottlieb @shaharzil
chore: delete circle ci and bump version
0cdf867
@orrgottlieb @shaharzil
update border colors
589f52b
@orrgottlieb @shaharzil
Update npm-publish.yml
4aba5ea
@orrgottlieb @shaharzil
Update package.json
a71c601
@orrgottlieb @shaharzil
revert: don't use svg2react
9ae1db4
@orrgottlieb @shaharzil
feat: add icons
7745cde
@orrgottlieb @shaharzil
update: metaData
7043d01
@orrgottlieb @shaharzil
update: metaData
90f1306
@orrgottlieb @shaharzil
add keys
dce763f
@orrgottlieb @shaharzil
typo: color name
4db6e08
@etaylib @shaharzil
file
5a3ec4f
@orrgottlieb @shaharzil
black theme, update colors to be more accessible
864231f
@orrgottlieb @shaharzil
black theme update
e8d71f7
@orrgottlieb @shaharzil
color fixes
25763c2
@orrgottlieb @shaharzil
fix: colors
2f6a039
@orrgottlieb @shaharzil
fix colors
df6d074
@yoavam @shaharzil
added apps icon
cdeeab2
@ofersh-monday @shaharzil
fixed svg images
f63581c
@orrgottlieb @shaharzil
fix: colors
9619f91
@shaharzil shaharzil requested a review from a team as a code owner February 12, 2024 16:47
@shaharzil shaharzil changed the title Monorepo style new chore: Monorepo style Feb 12, 2024
@shaharzil shaharzil closed this Feb 13, 2024
@shaharzil shaharzil deleted the monorepo-style-new branch March 5, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@shaharzil @vladmonday @orrgottlieb @etaylib @yoavam @ofersh-monday @amirbardugo @sahariko @laviomri @SergeyRoyt