Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Monorepo style #1947

Closed
wants to merge 48 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
1f0657d
Initial commit
Oct 6, 2020
1040d68
Update README.md
Oct 6, 2020
b4fc826
Committed hidden files which were missing during initial migration
Oct 6, 2020
cefef5e
Create npm-publish.yml
Oct 6, 2020
ab6caa6
Updated package.json to the new package's name and version
Oct 6, 2020
60f70b0
Fixed GitHub actions
Oct 6, 2020
33638ec
Added an install step to GitHub Actions
Oct 6, 2020
31f7a59
Bumped version to 0.0.4
Oct 6, 2020
5fedc49
doc: change urls to the new repository
vladmonday Oct 11, 2020
8f4139f
doc: change url to the new repo in package.json
vladmonday Oct 11, 2020
1d0e56e
feat: Icons initial commit
orrgottlieb Oct 11, 2020
0cdf867
chore: delete circle ci and bump version
orrgottlieb Oct 11, 2020
589f52b
update border colors
orrgottlieb Oct 11, 2020
4aba5ea
Update npm-publish.yml
orrgottlieb Oct 11, 2020
a71c601
Update package.json
orrgottlieb Oct 11, 2020
9ae1db4
revert: don't use svg2react
orrgottlieb Oct 12, 2020
7745cde
feat: add icons
orrgottlieb Oct 14, 2020
7043d01
update: metaData
orrgottlieb Oct 14, 2020
90f1306
update: metaData
orrgottlieb Oct 14, 2020
dce763f
add keys
orrgottlieb Nov 24, 2020
4db6e08
typo: color name
orrgottlieb Nov 24, 2020
5a3ec4f
file
etaylib Jan 16, 2021
864231f
black theme, update colors to be more accessible
orrgottlieb May 9, 2021
e8d71f7
black theme update
orrgottlieb May 10, 2021
25763c2
color fixes
orrgottlieb May 10, 2021
2f6a039
fix: colors
orrgottlieb May 10, 2021
df6d074
fix colors
orrgottlieb May 12, 2021
cdeeab2
added apps icon
yoavam Jun 13, 2021
f63581c
fixed svg images
ofersh-monday Jun 16, 2021
9619f91
fix: colors
orrgottlieb Jun 21, 2021
f69dd49
support placeholder with opacity for shimmer
Jul 7, 2021
3cb296e
add svg
amirbardugo Aug 3, 2021
a6cf9b2
add new color with opacity for on primary focus
Aug 8, 2021
32710e5
replace function with fit function
Aug 8, 2021
2b2bfc1
the icon itself
amirbardugo Oct 7, 2021
930f001
small fix in doc template icon
amirbardugo Oct 10, 2021
a89dad7
Add hacker theme
sahariko Oct 14, 2021
6d3d6fa
Add typography variables (#91)
Jan 24, 2022
20cecd5
Variables/hadas/fonts (#92)
Jan 24, 2022
cdd6651
fix font weight for h3 (#94)
Jan 26, 2022
eae15a4
change default Hebrew text font family (#99)
Feb 9, 2022
f263776
include stylelint config (#119)
laviomri Apr 17, 2022
66a6143
Publish storybook workflow (#244)
SergeyRoyt Sep 7, 2023
6a1c891
removed non relevant filrs
shaharzil Feb 12, 2024
13e38cc
move
shaharzil Feb 12, 2024
068fa2a
changed to yarn
shaharzil Feb 12, 2024
6ebe15f
changed paths
shaharzil Feb 12, 2024
880dafe
fixed buil
shaharzil Feb 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Please go over the checklist and make sure all conditions are met.
- [ ] Styles are added to `NewComponent.modules.scss` file inside the `NewComponent` folder.
- [ ] Component uses CSS Modules.
- [ ] Design is compatible with [Monday Design System](https://design.monday.com/).
- [ ] Styles are defined using [monday-ui-style](https://github.com/mondaycom/monday-ui-style) tokens
- [ ] Styles are defined using [monday-ui-style](https://github.com/mondaycom/monday-ui-react-core/tree/monorepo-style/packages/monday-ui-style) tokens
- [ ] Displays correctly in all the themes

#### Storybook
Expand Down
2 changes: 1 addition & 1 deletion packages/core/.storybook/preview.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Preview } from "@storybook/react";
import "monday-ui-style/dist/index.min.css";
import "../../style/dist/index.min.css";
import "vibe-storybook-components/index.css";
declare const preview: Preview;
export default preview;
2 changes: 1 addition & 1 deletion packages/core/.storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
StorybookLink
} from "vibe-storybook-components";
import { ComponentNameDecorator, PropsTable, RelatedComponentsDecorator } from "../src/storybook";
import "monday-ui-style/dist/index.min.css";
import "../../style/dist/index.min.css";
import "vibe-storybook-components/dist/index.css";
import introCode from "../src/storybook/stand-alone-documentaion/playground/playground-helpers";

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/style-imports.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
import "monday-ui-style/dist/index.min.css";
import "../../style/dist/index.min.css";
12 changes: 12 additions & 0 deletions packages/style/ICON_REQUEST.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Icon Request
> We are working hard to keep our icon library most relevant and consistent as possible, we want to make sure that we accommodate all the icon needs of our users

## New Icon Submission
Please open a PR with the title - "New Icon Request - IconName". In the body of the request please make sure to provide the following

- [ ] Icon Name
- [ ] Icon Description
- [ ] Usage Example
- [ ] Relevant Icon Examples.

You can also submit an icon design yourself in an SVG format. Our designers will go over the icon and give the appropriate PR comments
21 changes: 21 additions & 0 deletions packages/style/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2020 monday.com LTD

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
26 changes: 26 additions & 0 deletions packages/style/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# monday.com UI styles
This package includes all of the styling foundations of monday.com
Theme definition, colors, shadows, dimensions, icons, etc.

## Installation
```
npm install monday-ui-style
```

## Usage
We are building the icons using [Wix's svg2react-icon](https://github.com/wix/svg2react-icon) npm package it is generating a React component for each icon
``` javascript
import { IconName } from "monday-ui-style/dist/Icons"
import IconName from "monday-ui-style/dist/Icons/IconName"
```

## Adding a new icon
When adding a new icon please make sure of the following
- We don't have a similar icon - if so either replace the icon or make sure that we need another version of it
- Make sure to switch all fill/stroke.. colors to `currentColor`as we want to inherit the color of the font (we are not doing so automatically to leave the option to preserve svg with colors)
- Update the [metadata file](./src/Icons/iconsMetaData.js) for that icon


### New icon request
If you want us to create a non existing monday.com style icon open a PR with please see the [guidelines](ICON_REQUEST.md)

43 changes: 43 additions & 0 deletions packages/style/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"name": "monday-ui-style",
"version": "0.1.210",
"description": "Monday UI CSS Foundations",
"main": "dist/index.css",
"scripts": {
"auto:bump-patch": "node scripts/autobump_patch.js",
"auto:bump-minor": "node scripts/autobump_minor.js",
"auto:bump-major": "node scripts/autobump_major.js",
"test": "echo \"Error: no test specified\" && exit 1",
"compile-styles": "sass --style=expanded --precision 6 ./src/index.scss dist/index.css",
"css-minify": "cleancss --level 1 --format breaksWith=lf --output dist/index.min.css dist/index.css",
"build": "yarn compile-styles && yarn css-minify"
},
"peerDependencies": {
"react": ">=16.9.0",
"prop-types": "^15.7.2"
},
"repository": {
"type": "git",
"url": "git+https://github.com/mondaycom/monday-ui-react-core.git"
},
"keywords": [
"CSS",
"THEMES"
],
"author": "monday.com",
"license": "MIT",
"files": [
"src/",
"dist/",
"stylelint-config/"
],
"bugs": {
"url": "https://github.com/mondaycom/monday-ui-react-core/issues"
},
"homepage": "https://github.com/mondaycom/monday-ui-react-core#readme",
"devDependencies": {
"clean-css-cli": "^4.3.0",
"sass": "^1.70.0",
"prettier": "^2.0.5"
}
}
3 changes: 3 additions & 0 deletions packages/style/src/Icons/Apps.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions packages/style/src/Icons/Close.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/DocTemplate.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/style/src/Icons/Globe.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions packages/style/src/Icons/Group.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/LongText.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/Question.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/Radio.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/Retry.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/SearchThin.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/ShortText.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/style/src/Icons/Widgets.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading