GitHub Actions failing at installation of Node.js #309

PhilippImhof · 2024-08-08T11:54:33Z

A few days ago, some of my CI checks randomly failed at the install moodle-plugin-ci step. After a few retries, all checks finally passed. In the meantime, things have become worse. Currently, all checks are constantly failing. Some other developers reported the same in the dev chat.

 0/9 [>---------------------------]   0% < 1 sec [Starting install]
 2/9 [======>---------------------]  22% 15 secs [Moodle assets]
 3/9 [=========>------------------]  33% 15 secs [Install plugins]
 4/9 [============>---------------]  44% 16 secs [Installing Node.js]
In VendorInstaller.php line [12](https://github.com/PhilippImhof/moodle-quiz_essaydownload/actions/runs/10297980501/job/28511977093#step:6:13)9:
                                
  Node.js installation failed.  
                                
install [--moodle MOODLE] [--data DATA] [--repo REPO] [--branch BRANCH] [--plugin PLUGIN] [--db-type DB-TYPE] [--db-user DB-USER] [--db-pass DB-PASS] [--db-name DB-NAME] [--db-host DB-HOST] [--db-port DB-PORT] [--not-paths NOT-PATHS] [--not-names NOT-NAMES] [--extra-plugins EXTRA-PLUGINS] [--no-init] [--no-plugin-node] [--node-version NODE-VERSION]
Error: Process completed with exit code 1.

The text was updated successfully, but these errors were encountered:

kabalin · 2024-08-08T21:09:38Z

Test run on main branch fails too. Latest release of ubuntu-22.04 bumped nvm to 0.40.0. Looks to me as related nvm-sh/nvm#3405.

jrchamp · 2024-08-08T21:34:03Z

Maybe actions/setup-node is a more reliable way to install Node.js?

stronk7 · 2024-08-11T19:14:45Z

Coincidentally I arrived to this issue, worth checking it. It seems that some incompatibility between nvm (that we use to install the target nodejs version) and GitHub actions may be the root of the problem: nvm-sh/nvm#3405

A fix is being worked on, based on the last comments there…

stronk7 · 2024-08-11T19:16:39Z

Ah, @kabalin , just saw your comment now! Snap!

kabalin · 2024-08-11T19:36:49Z

A fix is being worked on, based on the last comments there…

Yeah, runner-images would need to be updated too following the fix in nvm, will take time. Temporary workaround is to install nvm 0.39.7 explicitly like at #310.

…we swap to temporary workaround (moodlehq/moodle-plugin-ci#310)

kabalin · 2024-08-13T08:51:39Z

Just to note, if we go for GH Action #303 (#53), this could be easily fixed for everyone without need to add workaround to individual workflows.

Ghostscypher · 2024-08-13T10:19:14Z

Solved mine temporarily by adding the following before Install moodle-plugin-ci step

      - name: Install NVM and Node
        run: |
          curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.0/install.sh | bash
          export NVM_DIR="$HOME/.nvm"
          [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
          nvm install 20
          nvm use 20

Just a temporary fix before this plugin is updated

kabalin · 2024-08-13T10:45:35Z

Just a temporary fix before this plugin is updated

So, you are installing version 20 explicitly, can you share the workflow? I would expect install step to fail as it only bypass node installation if NVM_DIR is undefined. Installing v0.40.0 is not necessary, it is already of that version in ubuntu-22.04 image we use (which actually cause of regression).

The easiest workaround for now is described in #310, a one-liner fix to downgrade nvm.

workaround for moodlehq/moodle-plugin-ci#309

ljharb · 2024-08-13T22:05:05Z

set +e is a much easier workaround than downgrading nvm, fwiw.

kabalin · 2024-08-14T09:18:29Z

set +e is a much easier workaround than downgrading nvm, fwiw.

Hmm, does not seem have effect (unless I am using it wrong way)
https://github.com/kabalin/moodle-plugin-ci/actions/runs/10384715590/job/28752387566#step:6:168

ljharb · 2024-08-15T21:30:28Z

You're using it correctly afaict (altho . /home/runner/.nvm/nvm.sh && nvm install && nvm use can just be . /home/runner/.nvm/nvm.sh --install), but I only see a moodle error and not the actual result of running that command?

This is a temporary fix and if this is fixed upstream we should consider reverting this.

…ci#309).

…-plugin-ci#309)

…ci#309).

Install 0.39.7 explicitly as part of vendor installation, so we have control over the version we use. For cases where nvm is not required (pre-installed in the image, use --no-nvm param for install command) Fixes moodlehq#309

Fixes moodlehq#309

kabalin · 2024-08-23T11:38:40Z

We fixed this in 4.5.4 release, those who added temporary workaround can safely remove it. Sorry for delaying the fix and thanks for your patience :)

jrchamp · 2024-08-23T17:27:51Z

@kabalin Thank you so much! Can a similar fix be applied to the 3.x branch? We still do some testing against older versions which do not work with 4.x

…-plugin-ci#309)

Remove workaround for moodlehq/moodle-plugin-ci#309

We should not rely on success exit status from nvm.sh loading. Fixes moodlehq#309

kabalin · 2024-08-29T16:45:16Z

@kabalin Thank you so much! Can a similar fix be applied to the 3.x branch? We still do some testing against older versions which do not work with 4.x

Yep, the fix has been released for 3.x too.

ljharb · 2024-08-29T18:07:09Z

fwiw v0.40.1 of nvm has been released, which should fix this issue.

matthewhilton mentioned this issue Aug 9, 2024

NodeJS install failure catalyst/catalyst-moodle-workflows#121

Closed

ferishili mentioned this issue Aug 9, 2024

GitHub actions are failing due to Node.js installation error Opencast-Moodle/moodle-workflows-opencast#5

Closed

luukverhoeven mentioned this issue Aug 9, 2024

Some Moodle versions showing the following Error: Not enough arguments (missing: "plugin"). catalyst/catalyst-moodle-workflows#120

Closed

mdjnelson mentioned this issue Aug 11, 2024

Improvement to the speed of the emailing certificate task (#531) mdjnelson/moodle-mod_customcert#610

Closed

kabalin mentioned this issue Aug 11, 2024

Use nvm 0.39.7 #310

Closed

MakinZeel pushed a commit to SE-Stuttgart/moodle-block_booksearch that referenced this issue Aug 12, 2024

Because of known GitHub Action issue (moodlehq/moodle-plugin-ci#309) …

3490ffb

…we swap to temporary workaround (moodlehq/moodle-plugin-ci#310)

SergioSim mentioned this issue Aug 12, 2024

💚(project) fix moodle-plugin-ci installation DatumAcademy/moodle-block_iagora#6

Merged

ngandrass mentioned this issue Aug 12, 2024

Fix: moodle-plugin-ci nvm issue on current GitHub action runners ngandrass/moodle-quiz_archiver#31

Merged

mk-kialo mentioned this issue Aug 12, 2024

Pm 46209 plugin review kialo/moodle-mod_kialo#9

Closed

jmorrph added a commit to ild-thl/moodle-block_disealytics that referenced this issue Aug 13, 2024

Use nvm 0.39.7

25a011d

workaround for moodlehq/moodle-plugin-ci#309

timhunt mentioned this issue Aug 14, 2024

Fix phpunit with Moodle 4.3 and PHP 8.2. turnitin/moodle-plagiarism_turnitin#734

Merged

janbritz mentioned this issue Aug 15, 2024

GitHub Actions schlagen fehl questionpy-org/moodle-qtype_questionpy#126

Closed

ponlawat-w mentioned this issue Aug 18, 2024

Reworked widget plugin system and fixed minor issues ponlawat-w/moodle-local_accessibility#13

Merged

mdjnelson added a commit to mdjnelson/moodle-mod_customcert that referenced this issue Aug 18, 2024

Fix GHA failing due to moodlehq/moodle-plugin-ci#309.

101be46

This is a temporary fix and if this is fixed upstream we should consider reverting this.

mdjnelson added a commit to mdjnelson/moodle-mod_customcert that referenced this issue Aug 18, 2024

Fix GHA failing due to moodlehq/moodle-plugin-ci#309.

2ef618b

This is a temporary fix and if this is fixed upstream we should consider reverting this.

mdjnelson added a commit to mdjnelson/moodle-mod_customcert that referenced this issue Aug 18, 2024

Fix GHA failing due to moodlehq/moodle-plugin-ci#309.

ce6c7f9

This is a temporary fix and if this is fixed upstream we should consider reverting this.

mdjnelson added a commit to mdjnelson/moodle-mod_customcert that referenced this issue Aug 18, 2024

Fix GHA failing due to moodlehq/moodle-plugin-ci#309.

be2ffac

This is a temporary fix and if this is fixed upstream we should consider reverting this.

gjb2048 added a commit to gjbarnard/moodle-format_grid that referenced this issue Aug 19, 2024

Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle-plugin-…

0036a5a

…ci#309).

semteacher added a commit to semteacher/moodle-mod_booking that referenced this issue Aug 19, 2024

GitHub: Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle…

ff0526a

…-plugin-ci#309)

FelixDiLenarda mentioned this issue Aug 20, 2024

Update CI workflow for moodle 404 innocampus/moodle-local_listcoursefiles#11

Merged

gjb2048 added a commit to gjbarnard/moodle-format_grid that referenced this issue Aug 20, 2024

Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle-plugin-…

519731c

…ci#309).

gjb2048 added a commit to gjbarnard/moodle-format_grid that referenced this issue Aug 20, 2024

Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle-plugin-…

aa69d59

…ci#309).

gjb2048 added a commit to gjbarnard/moodle-format_grid that referenced this issue Aug 20, 2024

Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle-plugin-…

4631679

…ci#309).

sh-csg added a commit to sh-csg/moodle-availability_user that referenced this issue Aug 21, 2024

Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle-plugin-…

d50a752

…ci#309).

FelixDiLenarda added a commit to FelixDiLenarda/moodle-local_listcoursefiles that referenced this issue Aug 22, 2024

Use nvm v0.39.7 (Temp. workaround for moodlehq/moodle-plugin-ci#309)

c7fe9b9

MartinGauk pushed a commit to innocampus/moodle-local_listcoursefiles that referenced this issue Aug 22, 2024

Use nvm v0.39.7 (Temp. workaround for moodlehq/moodle-plugin-ci#309)

becf7ec

kabalin mentioned this issue Aug 22, 2024

Add nvm installation to install step. #312

Draft

gjb2048 added a commit to Wunderbyte-GmbH/moodle-theme_lexa that referenced this issue Aug 22, 2024

Temporary workaround for moodlehq/moodle-plugin-ci#309.

aaac408

kabalin added a commit to kabalin/moodle-plugin-ci that referenced this issue Aug 23, 2024

Don't expect success exit status from nvm.sh loading.

d61c48c

Fixes moodlehq#309

kabalin mentioned this issue Aug 23, 2024

Fix nvm loading issue. #313

Merged

kabalin closed this as completed in #313 Aug 23, 2024

kabalin closed this as completed in 5be5de6 Aug 23, 2024

georgmaisser pushed a commit to Wunderbyte-GmbH/moodle-mod_booking that referenced this issue Aug 26, 2024

GitHub: Install nvm v0.39.7 (Temporary workaround for moodlehq/moodle…

4f07b50

…-plugin-ci#309)

janbritz mentioned this issue Aug 26, 2024

fix(ci): remove workaround questionpy-org/moodle-qtype_questionpy#128

Merged

FelixDiLenarda added a commit to FelixDiLenarda/moodle-local_listcoursefiles that referenced this issue Aug 28, 2024

Remove workaround for moodlehq/moodle-plugin-ci#309

d792a82

FelixDiLenarda mentioned this issue Aug 28, 2024

Remove workaround for moodlehq/moodle-plugin-ci#309 innocampus/moodle-local_listcoursefiles#13

Merged

FelixDiLenarda added a commit to innocampus/moodle-local_listcoursefiles that referenced this issue Aug 29, 2024

Merge pull request #13 from FelixDiLenarda/removeWorkaround

78138ea

Remove workaround for moodlehq/moodle-plugin-ci#309

kabalin added a commit to kabalin/moodle-plugin-ci that referenced this issue Aug 29, 2024

Fix nvm loading issue.

d204da6

We should not rely on success exit status from nvm.sh loading. Fixes moodlehq#309

jrchamp mentioned this issue Aug 29, 2024

Backport node.js fix to v3 branch #316

Closed

RiedleroD added a commit to necodeIT/lb_planner_plugin that referenced this issue Sep 30, 2024

fix: temporary workaround for moodlehq/moodle-plugin-ci#309

0e5f38c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Actions failing at installation of Node.js #309

GitHub Actions failing at installation of Node.js #309

PhilippImhof commented Aug 8, 2024

kabalin commented Aug 8, 2024

jrchamp commented Aug 8, 2024

stronk7 commented Aug 11, 2024 •

edited

Loading

stronk7 commented Aug 11, 2024

kabalin commented Aug 11, 2024 •

edited

Loading

kabalin commented Aug 13, 2024

Ghostscypher commented Aug 13, 2024 •

edited

Loading

kabalin commented Aug 13, 2024 •

edited

Loading

ljharb commented Aug 13, 2024

kabalin commented Aug 14, 2024

ljharb commented Aug 15, 2024

kabalin commented Aug 23, 2024

jrchamp commented Aug 23, 2024

kabalin commented Aug 29, 2024

ljharb commented Aug 29, 2024

GitHub Actions failing at installation of Node.js #309

GitHub Actions failing at installation of Node.js #309

Comments

PhilippImhof commented Aug 8, 2024

kabalin commented Aug 8, 2024

jrchamp commented Aug 8, 2024

stronk7 commented Aug 11, 2024 • edited Loading

stronk7 commented Aug 11, 2024

kabalin commented Aug 11, 2024 • edited Loading

kabalin commented Aug 13, 2024

Ghostscypher commented Aug 13, 2024 • edited Loading

kabalin commented Aug 13, 2024 • edited Loading

ljharb commented Aug 13, 2024

kabalin commented Aug 14, 2024

ljharb commented Aug 15, 2024

kabalin commented Aug 23, 2024

jrchamp commented Aug 23, 2024

kabalin commented Aug 29, 2024

ljharb commented Aug 29, 2024

stronk7 commented Aug 11, 2024 •

edited

Loading

kabalin commented Aug 11, 2024 •

edited

Loading

Ghostscypher commented Aug 13, 2024 •

edited

Loading

kabalin commented Aug 13, 2024 •

edited

Loading