Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nvm 0.39.7 #310

Closed
wants to merge 1 commit into from
Closed

Use nvm 0.39.7 #310

wants to merge 1 commit into from

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented Aug 11, 2024

This is a temporary workaround for #309. Not sure if we need to make it permanent and advice changing workflows, depends on how quickly the issue will be fixed upstream.

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (3842ad1) to head (8c02395).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #310   +/-   ##
=========================================
  Coverage     88.25%   88.25%           
+ Complexity      739      737    -2     
=========================================
  Files            76       76           
  Lines          2274     2274           
=========================================
  Hits           2007     2007           
  Misses          267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kabalin kabalin changed the title Use nvm 0.39.7 to overcome 0.40.0 regression issue Draft: Use nvm 0.39.7 to overcome 0.40.0 regression issue Aug 11, 2024
@kabalin kabalin marked this pull request as draft August 11, 2024 19:34
martignoni added a commit to moodlebox/moodle-tool_moodlebox that referenced this pull request Aug 11, 2024
MakinZeel pushed a commit to SE-Stuttgart/moodle-block_booksearch that referenced this pull request Aug 12, 2024
@kabalin kabalin changed the title Draft: Use nvm 0.39.7 to overcome 0.40.0 regression issue Use nvm 0.39.7 Aug 19, 2024
@kabalin kabalin marked this pull request as ready for review August 19, 2024 22:36
This is to have control over image supplied version to prevent
regression similar to moodlehq#309.
@kabalin
Copy link
Member Author

kabalin commented Aug 19, 2024

I suggest to install 0.39.7 explicitly as part of initialisation step, so we have control over the version we use. Also ubuntu-24.04 runner image does not have nvm, so this step will be needed sooner or later.

JayBraker added a commit to rwthmoodle/moodle-mod_pdfannotator that referenced this pull request Aug 22, 2024
@kabalin
Copy link
Member Author

kabalin commented Aug 22, 2024

Closing in favour of #312

@kabalin kabalin closed this Aug 22, 2024
JayBraker added a commit to rwthmoodle/moodle-mod_pdfannotator that referenced this pull request Aug 22, 2024
* Fix Syntax for moodle-plugin-ci: Provide path to plugin source as last argument

* Temporary fix for CI moodlehq/moodle-plugin-ci#310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant