Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvm installation to install step. #312

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented Aug 22, 2024

Install 0.39.7 explicitly as part of vendor installation, so we have control over the version we use.

For cases where nvm is not required (pre-installed in the image, use --no-nvm param for install command)

Fixes #309

@kabalin kabalin requested a review from stronk7 August 22, 2024 12:08
@kabalin kabalin mentioned this pull request Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (3842ad1) to head (b16a63a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/Installer/VendorInstaller.php 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #312      +/-   ##
============================================
+ Coverage     88.25%   88.30%   +0.04%     
- Complexity      739      742       +3     
============================================
  Files            76       76              
  Lines          2274     2291      +17     
============================================
+ Hits           2007     2023      +16     
- Misses          267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stronk7
stronk7 previously approved these changes Aug 22, 2024
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kabalin, this looks good enough. I've just added a couple of details for your consideration.

And then there is the thing (discussed in the chat) about, in some of the tests, always remove any potential $HOME/.nvm dir that may be there to ensure that things are installed (or skipped) properly.

Feel free to merge it once amended, 100%.

One last suggestion, maybe I'd try, with some real plugin, both using 22.04 and 24.04 and verify that it's working in both cases. Sure (99%) it does, but trying with a real plugin is reassuring, IMO.

Ciao :-)

docs/CHANGELOG.md Outdated Show resolved Hide resolved
src/Installer/VendorInstaller.php Outdated Show resolved Hide resolved
Install 0.39.7 explicitly as part of vendor installation, so we have control over the version we use.

For cases where nvm is not required (pre-installed in the image, use
--no-nvm param for install command)

Fixes moodlehq#309
@kabalin
Copy link
Member Author

kabalin commented Aug 23, 2024

Converting this to draft due to ubuntu 24.04 incompatibility (different default installation dir), we might get back to this in future.

@stronk7 stronk7 mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions failing at installation of Node.js
2 participants