Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #2973

Merged
merged 2 commits into from
Sep 26, 2024
Merged

chore: fix some comments #2973

merged 2 commits into from
Sep 26, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Sep 24, 2024

What does it do?

Closes #2904

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Signed-off-by: shenpengfeng <xinhangzhou@icloud.com>
@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Sep 24, 2024
@RomarQ RomarQ self-assigned this Sep 24, 2024
Copy link
Contributor

github-actions bot commented Sep 24, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2196 KB (no changes) ✅

Moonbeam runtime: 2140 KB (no changes) ✅

Moonriver runtime: 2132 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2196 KB (+236 KB compared to latest release) ⚠️

Moonbeam runtime: 2140 KB (+216 KB compared to latest release) ⚠️

Moonriver runtime: 2132 KB (+208 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Coverage Report

@@                Coverage Diff                 @@
##           master   rq/fix-comments     +/-   ##
==================================================
  Coverage   79.31%            79.31%   0.00%     
  Files         298               298             
  Lines       87140             87140             
==================================================
  Hits        69114             69114             
  Misses      18026             18026             
Files Changed Coverage

Coverage generated Wed Sep 25 19:18:39 UTC 2024

@RomarQ RomarQ added the I5-documentation 📄 Documentation needs fixing, improving or augmenting. label Sep 26, 2024
@noandrea noandrea merged commit 9ff47ee into master Sep 26, 2024
44 checks passed
@noandrea noandrea deleted the rq/fix-comments branch September 26, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) I5-documentation 📄 Documentation needs fixing, improving or augmenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants