Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #2973

Merged
merged 2 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/rpc/trace/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
//! executor.
//!
//! The implementation is composed of multiple tasks :
//! - Many calls the the RPC handler `Trace::filter`, communicating with the main task.
//! - Many calls the RPC handler `Trace::filter`, communicating with the main task.
//! - A main `CacheTask` managing the cache and the communication between tasks.
//! - For each traced block an async task responsible to wait for a permit, spawn a blocking
//! task and waiting for the result, then send it to the main `CacheTask`.
Expand Down
2 changes: 1 addition & 1 deletion test/suites/dev/moonbase/test-orbiters/test-orbiters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describeSuite({
expect(notifyInactiveOrbiter.result!.error!.name).toEqual("CannotBeNotifiedAsInactive");

// Call to mark an orbiterPool that has not produced blocks offline
// should succeed but it should be an noop (pool will still be active) if there are is an
// should succeed but it should be a noop (pool will still be active) if there is an
// active orbiter in the pool
await context.createBlock(
context
Expand Down
2 changes: 1 addition & 1 deletion test/suites/tracing-tests/test-trace-filter-reorg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describeSuite({
// extrinsics into the pool.
//
// This block however will contain the transaction with nonce 1 but the
// chain don't expect this nonce so the the Ethereum transaction in not executed.
// chain don't expect this nonce so the Ethereum transaction in not executed.
// However it is still in the list of extrinsics for this block.
const block3a = await context.createBlock([], {
parentHash: block2a.block.hash,
Expand Down
Loading