Skip to content

Comments

MOSU refactor: profile null 체크 추가#303

Merged
wlgns12370 merged 1 commit intoprodfrom
develop
Aug 10, 2025
Merged

MOSU refactor: profile null 체크 추가#303
wlgns12370 merged 1 commit intoprodfrom
develop

Conversation

@wlgns12370
Copy link
Contributor

No description provided.

@wlgns12370 wlgns12370 merged commit a399e29 into prod Aug 10, 2025
2 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @wlgns12370, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented a refactoring change to enhance the robustness of the profile editing functionality. The primary purpose of this change is to prevent potential runtime errors by explicitly handling cases where optional profile information, specifically school details, might be absent from an update request. This ensures that the application gracefully handles missing data without crashing, improving overall stability.

Highlights

  • Defensive Programming: Null Check for School Information: I've added a null check to the schoolInfo field within the edit method of the ProfileJpaEntity. This ensures that if schoolInfo is not provided in the EditProfileRequest, the application will not throw a NullPointerException when attempting to call toEntity() on a null object.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds a null check to prevent a NullPointerException when editing a user's profile with no school information. The change is a good defensive measure. I've provided one suggestion to refactor this line using java.util.Optional for a more modern and slightly more efficient implementation.

this.email = request.email();
this.education = request.education();
this.schoolInfo = request.schoolInfo().toEntity();
this.schoolInfo = request.schoolInfo() != null ? request.schoolInfo().toEntity() : null;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Good catch adding the null check to prevent a NullPointerException. For a more modern and fluent approach, you could use java.util.Optional. This avoids the duplicate call to request.schoolInfo() and can improve readability.

You'll need to add an import for java.util.Optional at the top of the file.

Suggested change
this.schoolInfo = request.schoolInfo() != null ? request.schoolInfo().toEntity() : null;
this.schoolInfo = java.util.Optional.ofNullable(request.schoolInfo()).map(info -> info.toEntity()).orElse(null);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant