Skip to content

MOSU refactor: profile null 체크 추가 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wlgns12370 merged 1 commit into from
Aug 10, 2025
Merged

MOSU refactor: profile null 체크 추가 #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/life/mosu/mosuserver/domain/profile/entity/ProfileJpaEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public ProfileJpaEntity(
public void edit(final EditProfileRequest request) {
this.email = request.email();
this.education = request.education();
this.schoolInfo = request.schoolInfo().toEntity();
this.schoolInfo = request.schoolInfo() != null ? request.schoolInfo().toEntity() : null;
Copy link

@gemini-code-assist gemini-code-assist bot Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Good catch adding the null check to prevent a NullPointerException. For a more modern and fluent approach, you could use java.util.Optional. This avoids the duplicate call to request.schoolInfo() and can improve readability.

You'll need to add an import for java.util.Optional at the top of the file.

Suggested change
this.schoolInfo = request.schoolInfo() != null ? request.schoolInfo().toEntity() : null;
this.schoolInfo = java.util.Optional.ofNullable(request.schoolInfo()).map(info -> info.toEntity()).orElse(null);

this.grade = request.grade();
}

Expand Down