Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #2837

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Upgrade GitHub Actions #2837

merged 2 commits into from
Oct 4, 2023

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 4, 2023

Fix a flake8 error and move safety to a separate GitHub Action so we do not ignore Python test errors.

@cclauss cclauss force-pushed the Upgrade-GitHub-Actions branch 2 times, most recently from 59b17cc to 2332867 Compare October 4, 2023 09:13
@cclauss cclauss force-pushed the Upgrade-GitHub-Actions branch from 0451a64 to fec460b Compare October 4, 2023 09:19
Copy link
Member

@MarcelCoding MarcelCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Changing the default branch would be helpful, that Dependabot would start working. Dependabot only checks the default branch for the default branch.

The configuration is already existing:
https://github.com/motioneye-project/motioneye/blob/dev/.github/dependabot.yaml

@cclauss cclauss merged commit 4d33d58 into dev Oct 4, 2023
16 of 17 checks passed
@cclauss cclauss deleted the Upgrade-GitHub-Actions branch October 4, 2023 10:31
@MichaIng
Copy link
Member

MichaIng commented Oct 4, 2023

Would be good to check whether newly added tests are green before merging them 😉.

@cclauss
If I am no mistaken, safety checks all Python packages installed locally and globally on the system, and the GitHub runners come with a lot of which are not needed for motionEye, especially where we do not enforce any max version.

I think the test how it is currently added does not make any sense. It tests only the default GitHub runner Python environment, which has nothing to do with motionEye. We'd need to install motionEye, at best into a venv, to not test the GitHub runner, but what we really do install for motionEye?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants