-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subscribed
/unsub_reason
fields to waitlist
#707
Conversation
subscribed
/unsub_reason
fields to waitlist
8c5506e
to
5e18525
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a trace of records with subscribed=False, the only way to keep to waitlist subscriptions in sync in Acoustic is todelete all entries of the waitlist relational table for a given contact, and re-add their subscriptions.
Not necessarily. In #571 we discussed the idea of using some to_delete
queue. That discussion was focused on deleting entire contacts, but a similar design might also be useful for removing people from waitlists.
If it's a requirement to capture unsub_reason
though, (i.e. if marketing will use this column for some reason) then having this "soft delete" approach would make sense.
Co-authored-by: grahamalama <gbeckley@mozilla.com>
This will be necessary for an efficient implementation of #561 . Without that, we cannot synchronize unsubscriptions efficiently on Acoustic. Without a trace of records with
subscribed=False
, the only way to keep to waitlist subscriptions in sync in Acoustic is todelete all entries of thewaitlist
relational table for a given contact, and re-add their subscriptions.With this PR, the waitlist implementation will follow what we want for newsletters in #562
subscribed
tofalse
instead of deleting waitlist recordsunsub_reason